LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Remove redundant display of free swap space in show_mem()
Date: Mon, 10 Mar 2008 17:28:37 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0803101720580.3398@blonde.site> (raw)
In-Reply-To: <87abl68rdd.fsf@saeurebad.de>

On Mon, 10 Mar 2008, Johannes Weiner wrote:
> From: Johannes Weiner <hannes@saeurebad.de>
> 
> show_free_areas() already displays free swap space, no need to do it a
> second time in show_mem() which calls the former anyway.
> 
> Signed-off-by: Johannes Weiner <hannes@saeurebad.de>

I heartily approve of this; and yes, it's the per-arch one which should
go (since its "alignment" looks nasty).  But there's a lot more arches
than just x86 which should be fixed (and so rather more work, preparing
those patches for the various maintainers) - is that something you'd
have time to do?  (Don't worry, "No" is a perfectly fair answer, and
it's no way essential that all change at once.)

Thanks,
Hugh

> ---
>  arch/x86/mm/init_64.c    |    3 ---
>  arch/x86/mm/pgtable_32.c |    1 -
>  2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index 8230d1e..94baf63 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -89,9 +89,6 @@ void show_mem(void)
>  
>  	printk(KERN_INFO "Mem-info:\n");
>  	show_free_areas();
> -	printk(KERN_INFO "Free swap:       %6ldkB\n",
> -		nr_swap_pages << (PAGE_SHIFT-10));
> -
>  	for_each_online_pgdat(pgdat) {
>  		for (i = 0; i < pgdat->node_spanned_pages; ++i) {
>  			/*
> diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c
> index 6530201..bacae27 100644
> --- a/arch/x86/mm/pgtable_32.c
> +++ b/arch/x86/mm/pgtable_32.c
> @@ -32,7 +32,6 @@ void show_mem(void)
>  
>  	printk(KERN_INFO "Mem-info:\n");
>  	show_free_areas();
> -	printk(KERN_INFO "Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
>  	for_each_online_pgdat(pgdat) {
>  		pgdat_resize_lock(pgdat, &flags);
>  		for (i = 0; i < pgdat->node_spanned_pages; ++i) {

  reply	other threads:[~2008-03-10 17:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 16:40 Johannes Weiner
2008-03-10 17:28 ` Hugh Dickins [this message]
2008-03-10 18:47   ` Johannes Weiner
2008-03-11  9:14 ` Ingo Molnar
2008-03-10 20:10 [PATCH] arm: " Johannes Weiner
2008-03-10 20:10 ` [PATCH] x86: " Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0803101720580.3398@blonde.site \
    --to=hugh@veritas.com \
    --cc=hannes@saeurebad.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: [PATCH] x86: Remove redundant display of free swap space in show_mem()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).