LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hans Schou <linux@schou.dk>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SiS55x, another x86 CPU
Date: Mon, 13 Oct 2008 22:56:00 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0810132240010.8901@sko.w0.dk> (raw)
In-Reply-To: <87d4i5rq7i.fsf@basil.nowhere.org>

On Mon, 13 Oct 2008, Andi Kleen wrote:

> Hans Schou <linux@schou.dk> writes:
>
>
>> flags           : fpu tsc cx8 mmx
>>
>> Instruction and data cache is 8KB each it says in the datasheet. I'm
>> not sure but it does not look like it is written in dmesg.
>>
>> ACPI sleep supports S1 S2 S3 S4 S5.
>>
>> CPU power states supports C0 C1 C2 C3.
>>
>> See attachment. (I hope it gets here!)
>
> Your attachment seems to be windows line end damaged.

Strange, Pine usually do it right with file attachments.
(what is "windows line end damaged"?)

> Also the changes are so small that it's not worth adding a CONFIG 
> for it. Just add it unconditionally.

I was not trying to invent anything. It is almost a copy of the UMC 
CPU, except that it is 586 code.

> And hardcoding the cache size for all of SiS seems a bit extreme. 
> What happens when SiS ever brings out another part with different 
> caches? Ideally figure out some way to detect this particular CPU 
> and only use 8 KB only for that. Alternatively ignore it (there's 
> nothing really in the kernel that uses the cache sizes anyways)

In that case the cache could be deleted.

One annoying thing is that the "model name" in /proc/cpuinfo is 
written as "00/55" instead of "SiS55x" when the CPU is not detected.

The worst problem is that an unknown CPU writes:
printk(KERN_ERR "CPU: Your system may be unstable.\n");
and the SiS55x is not unstable. Not until now at least and it has been 
on the market for 5 years.

Maybe the message could be changed to something less catastrophic when 
CPU is unknown.

So, many solutions could be be better than the one there is now.
And if the new solution will be usefull for other unknown CPU's it 
will be even better.

/hans

  reply	other threads:[~2008-10-13 20:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-11 21:24 Hans Schou
2008-10-13  5:58 ` Andi Kleen
2008-10-13 20:56   ` Hans Schou [this message]
2008-10-14  6:06     ` Andi Kleen
2008-10-14 17:38       ` Hans Schou
2008-10-15 10:06         ` Andi Kleen
2008-10-15 19:51           ` Geert Uytterhoeven
2008-10-15 22:37             ` Hans Schou
2008-10-16  7:09               ` Geert Uytterhoeven
2008-10-16 19:01                 ` Hans Schou
2008-10-16 19:18                   ` Maciej W. Rozycki
2008-10-16 20:13                     ` Hans Schou
2008-10-15 22:24         ` Hans Schou
     [not found] ` <48F6E3DE.10206@zytor.com>
2008-10-16 18:47   ` Hans Schou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0810132240010.8901@sko.w0.dk \
    --to=linux@schou.dk \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] SiS55x, another x86 CPU' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).