LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
To: James.Bottomley@HansenPartnership.com
Cc: linux-scsi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 10/10] arcmsr: add missing braces to multistatement if block
Date: Thu, 30 Oct 2008 13:47:20 +0200 (EET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0810301345050.7072@wrl-59.cs.helsinki.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0810301307160.7072@wrl-59.cs.helsinki.fi>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1001 bytes --]


Funny, there are plenty of the braces in case block where
one does not need them while in here they seem to be
forgotten.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 drivers/scsi/arcmsr/arcmsr_hba.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index f91f79c..b57834b 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -673,10 +673,11 @@ static void arcmsr_report_ccb_state(struct AdapterControlBlock *acb, \
 	id = ccb->pcmd->device->id;
 	lun = ccb->pcmd->device->lun;
 	if (!(flag_ccb & ARCMSR_CCBREPLY_FLAG_ERROR)) {
-		if (acb->devstate[id][lun] == ARECA_RAID_GONE)
+		if (acb->devstate[id][lun] == ARECA_RAID_GONE) {
 			acb->devstate[id][lun] = ARECA_RAID_GOOD;
 			ccb->pcmd->result = DID_OK << 16;
 			arcmsr_ccb_complete(ccb, 1);
+		}
 	} else {
 		switch (ccb->arcmsr_cdb.DeviceStatus) {
 		case ARCMSR_DEV_SELECT_TIMEOUT: {
-- 
1.5.2.2

  parent reply	other threads:[~2008-10-30 11:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 11:09 [PATCH 01/10] sound/ice1712: indentation & braces disagree - add braces Ilpo Järvinen
2008-10-30 11:11 ` [PATCH 02/10] consolemap: indentation & braces disagree - reindent Ilpo Järvinen
2008-10-30 11:32 ` [PATCH 03/10] misdn: indentation & braces disagree - add braces Ilpo Järvinen
2008-10-30 11:34 ` [PATCH 04/10] misdn: one handmade ARRAY_SIZE converted Ilpo Järvinen
2008-10-30 11:35 ` [PATCH 05/10] misdn: indentation and braces disagree - add braces Ilpo Järvinen
2008-10-30 11:39 ` [PATCH 07/10] rdma/nes: reindent mis-indented spinlocks Ilpo Järvinen
2008-11-03  5:34   ` Roland Dreier
2008-10-30 11:40 ` [PATCH 01/10] sound/ice1712: indentation & braces disagree - add braces Takashi Iwai
2008-10-30 11:47 ` Ilpo Järvinen [this message]
2008-10-30 11:56 ` [PATCH 06/10] usbtmc: indent & braces disagree, something else is desired Ilpo Järvinen
2008-11-12 20:25   ` patch usb-usbtmc-indent-braces-disagree-something-else-is-desired.patch added to gregkh-2.6 tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0810301345050.7072@wrl-59.cs.helsinki.fi \
    --to=ilpo.jarvinen@helsinki.fi \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --subject='Re: [PATCH 10/10] arcmsr: add missing braces to multistatement if block' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).