LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] usbtmc: Fix type conflict
@ 2008-10-30 12:10 Ilpo Järvinen
  2008-10-30 16:15 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Ilpo Järvinen @ 2008-10-30 12:10 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: LKML

[-- Attachment #1: Type: TEXT/PLAIN, Size: 820 bytes --]


While making the other change, I noticed this:

  CC      drivers/usb/class/usbtmc.o
drivers/usb/class/usbtmc.c: In function 'usbtmc_ioctl_abort_bulk_in':
drivers/usb/class/usbtmc.c:164: warning: comparison is always false due to
limited range of data type

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 drivers/usb/class/usbtmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c
index 711a9fa..9f7fefd 100644
--- a/drivers/usb/class/usbtmc.c
+++ b/drivers/usb/class/usbtmc.c
@@ -134,7 +134,7 @@ static int usbtmc_release(struct inode *inode, struct file *file)
 
 static int usbtmc_ioctl_abort_bulk_in(struct usbtmc_device_data *data)
 {
-	char *buffer;
+	u8 *buffer;
 	struct device *dev;
 	int rv;
 	int n;
-- 
1.5.2.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] usbtmc: Fix type conflict
  2008-10-30 12:10 [PATCH] usbtmc: Fix type conflict Ilpo Järvinen
@ 2008-10-30 16:15 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2008-10-30 16:15 UTC (permalink / raw)
  To: Ilpo Järvinen; +Cc: LKML

On Thu, Oct 30, 2008 at 02:10:33PM +0200, Ilpo Järvinen wrote:
> 
> While making the other change, I noticed this:
> 
>   CC      drivers/usb/class/usbtmc.o
> drivers/usb/class/usbtmc.c: In function 'usbtmc_ioctl_abort_bulk_in':
> drivers/usb/class/usbtmc.c:164: warning: comparison is always false due to
> limited range of data type

I just sent a patch to Linus that did exactly this :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-30 16:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-30 12:10 [PATCH] usbtmc: Fix type conflict Ilpo Järvinen
2008-10-30 16:15 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).