LKML Archive on
help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <>
To: Adrian Bunk <>
Cc: Ralf Baechle <>,
	Franck Bui-Huu <>,,,
	Andrew Morton <>,
Subject: Re: [PATCH] Discardable strings for init and exit sections
Date: Tue, 23 Oct 2007 17:57:38 +0100 (BST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 12 Oct 2007, Adrian Bunk wrote:

> - Most of the string annotations are (naturally) dev{init,exit}
>   annotations, and bugs there are therefore in configurations that have
>   only extremely low testing coverage during -rc.
> - I'm counting 22 annotations in the driver Maciej converted as an
>   example. When estimating the number of possible annotations based
>   on the number of C files in the kernel I'm getting a six digit
>   number.
> No matter how hard it would be to teach gcc about it, when thinking of 
> the amount of __*init*/__*exit* bugs we already have I simply can't 
> imagine the string annotations as a maintainable solution.

 Well, it is up to the maintainer of code in question to get it right if 
interested.  Otherwise having no annotation and leaving the relevant 
strings resident in the memory throughout the lifespan of the system is a 
valid and perfectly working option.

 If you worry about the reverse case, where an annotation should be 
removed because the containing function is no longer __*init*/__*exit*, 
then I think `modpost' does a reasonably good job finding such places.


  reply	other threads:[~2007-10-23 16:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12 16:50 Maciej W. Rozycki
2007-10-12 17:19 ` Adrian Bunk
2007-10-12 17:52   ` Ralf Baechle
2007-10-12 18:15     ` Adrian Bunk
2007-10-23 16:57       ` Maciej W. Rozycki [this message]
2007-10-23 17:12         ` Adrian Bunk
2007-10-23 17:25           ` Sam Ravnborg
2007-10-12 17:45 ` Sam Ravnborg
2007-10-23 17:23   ` Maciej W. Rozycki
2007-10-23 17:27     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Discardable strings for init and exit sections' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).