LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 0/2] net: xlinx: mdio: recheck condition after timeout
@ 2018-10-30  9:31 Kurt Kanzenbach
  2018-10-30  9:31 ` [PATCH 1/2] net: axienet: recheck condition after timeout in mdio_wait() Kurt Kanzenbach
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Kurt Kanzenbach @ 2018-10-30  9:31 UTC (permalink / raw)
  To: Anirudha Sarangi, John Linn, David S. Miller
  Cc: Michal Simek, Radhey Shyam Pandey, Andrew Lunn, YueHaibing,
	netdev, linux-arm-kernel, linux-kernel, Kurt Kanzenbach

Hi,

the Xilinx mdio wait functions may return false positives under certain
circumstances: If the functions get preempted between reading the corresponding
mdio register and checking for the timeout, they could falsely indicate a
timeout.

In order to avoid the issue, the condition should be rechecked in the timeout
case.

Kurt Kanzenbach (2):
  net: axienet: recheck condition after timeout in mdio_wait()
  net: xilinx_emaclite: recheck condition after timeout in mdio_wait()

 drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 21 ++++++++++++++++-----
 drivers/net/ethernet/xilinx/xilinx_emaclite.c     | 20 +++++++++++++++-----
 2 files changed, 31 insertions(+), 10 deletions(-)

-- 
2.11.0


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-11-05  9:16 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30  9:31 [PATCH 0/2] net: xlinx: mdio: recheck condition after timeout Kurt Kanzenbach
2018-10-30  9:31 ` [PATCH 1/2] net: axienet: recheck condition after timeout in mdio_wait() Kurt Kanzenbach
2018-10-30 18:25   ` David Miller
2018-10-31 13:06     ` Kurt Kanzenbach
2018-11-05  9:16     ` Sebastian Andrzej Siewior
2018-10-30  9:31 ` [PATCH 2/2] net: xilinx_emaclite: " Kurt Kanzenbach
2018-10-30 12:10   ` Andrew Lunn
2018-10-30 12:58     ` Radhey Shyam Pandey
2018-10-30 18:25   ` David Miller
2018-10-30 12:08 ` [PATCH 0/2] net: xlinx: mdio: recheck condition after timeout Andrew Lunn
2018-10-30 13:47   ` Kurt Kanzenbach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).