LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Alim Akhtar <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Evan Green <evgreen@chromium.org>, Bean Huo <beanhuo@micron.com>,
	Pedro Sousa <pedrom.sousa@synopsys.com>
Cc: Avi Shchislowski <Avi.Shchislowski@wdc.com>,
	Alex Lemberg <Alex.Lemberg@wdc.com>
Subject: RE: [PATCH] scsi: ufs: Check that space was properly alloced in copy_query_response
Date: Mon, 3 Jun 2019 08:37:42 +0000	[thread overview]
Message-ID: <SN6PR04MB492583D987B1F25A0541EBAFFC140@SN6PR04MB4925.namprd04.prod.outlook.com> (raw)
In-Reply-To: <cd9f0d7b-8ce6-e432-e1df-c4316b191156@samsung.com>

Hi Alim,
Thank you for your review.
Sorry for the late response - I was away for a couple of weeks.

Thanks,
Avri

> Subject: Re: [PATCH] scsi: ufs: Check that space was properly alloced in
> copy_query_response
> 
> Hi Avri
> 
> On 5/21/19 1:54 PM, Avri Altman wrote:
> > struct ufs_dev_cmd is the main container that supports device management
> > commands. In the case of a read descriptor request, we assume that the
> > proper space was allocated in dev_cmd to hold the returning descriptor.
> >
> > This is no longer true, as there are flows that doesn't use dev_cmd
> > for device management requests, and was wrong in the first place.
> >
> Can you please put some light on those flows? Are those platform
> specific? Just curious.
No, actually its quite simplistic.
__ufshcd_query_descriptor set dev_cmd.query.descriptor 
to point to its designated space before sending the read descriptor query,
and to null once it's done.
But it doesn't check it in ufshcd_copy_query_response when the query
returns from the device, which it should, as I indicated in the commit log.


> This change looks ok to me. I hope you have tested this patch.
Yes I did.

> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


  reply	other threads:[~2019-06-03  8:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190521082527epcas1p44fe0c4659549ae265c9d59ef7844e57e@epcas1p4.samsung.com>
2019-05-21  8:24 ` Avri Altman
2019-05-28  4:07   ` Alim Akhtar
2019-06-03  8:37     ` Avri Altman [this message]
2019-05-28  7:51   ` [EXT] " Bean Huo (beanhuo)
2019-06-05  2:11   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR04MB492583D987B1F25A0541EBAFFC140@SN6PR04MB4925.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=Alex.Lemberg@wdc.com \
    --cc=Avi.Shchislowski@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=beanhuo@micron.com \
    --cc=evgreen@chromium.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=pedrom.sousa@synopsys.com \
    --subject='RE: [PATCH] scsi: ufs: Check that space was properly alloced in copy_query_response' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).