RE: [PATCH] net: stmmac: dwmac-visconti: Make use of the helper function dev_err_probe()

[<nobuhiro1.iwamatsu@toshiba.co.jp>]

Hi,

> -----Original Message-----
> From: Cai Huoqing [mailto:caihuoqing@baidu.com]
> Sent: Thursday, September 16, 2021 4:38 PM
> To: caihuoqing@baidu.com
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue <alexandre.torgue@foss.st.com>; Jose Abreu
> <joabreu@synopsys.com>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Maxime Coquelin
> <mcoquelin.stm32@gmail.com>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>;
> netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] net: stmmac: dwmac-visconti: Make use of the helper function dev_err_probe()
> 
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> And using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> index d046e33b8a29..66fc8be34bb7 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> @@ -171,10 +171,9 @@ static int visconti_eth_clock_probe(struct platform_device *pdev,
>  	int err;
> 
>  	dwmac->phy_ref_clk = devm_clk_get(&pdev->dev, "phy_ref_clk");
> -	if (IS_ERR(dwmac->phy_ref_clk)) {
> -		dev_err(&pdev->dev, "phy_ref_clk clock not found.\n");
> -		return PTR_ERR(dwmac->phy_ref_clk);
> -	}
> +	if (IS_ERR(dwmac->phy_ref_clk))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(dwmac->phy_ref_clk),
> +				     "phy_ref_clk clock not found.\n");
> 
>  	err = clk_prepare_enable(dwmac->phy_ref_clk);
>  	if (err < 0) {
> --
> 2.25.1

Best regards,
  Nobuhiro