LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: [PATCH V2] ASoC: cs42xx8: Add reset gpio handling
@ 2019-05-16 11:09 S.j. Wang
  2019-05-16 11:12 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: S.j. Wang @ 2019-05-16 11:09 UTC (permalink / raw)
  To: Mark Brown
  Cc: brian.austin, Paul.Handrigan, lgirdwood, perex, tiwai,
	alsa-devel, linux-kernel

Hi

> 
> On Thu, May 16, 2019 at 06:04:58AM +0000, S.j. Wang wrote:
> 
> > +	cs42xx8->gpiod_reset = devm_gpiod_get_optional(dev, "reset",
> > +							GPIOD_OUT_HIGH);
> > +	if (IS_ERR(cs42xx8->gpiod_reset))
> > +		return PTR_ERR(cs42xx8->gpiod_reset);
> 
> You also need a binding document update for this.
ok, will send v3

best regards
wang shengjiu

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH V2] ASoC: cs42xx8: Add reset gpio handling
  2019-05-16 11:09 [PATCH V2] ASoC: cs42xx8: Add reset gpio handling S.j. Wang
@ 2019-05-16 11:12 ` Mark Brown
  2019-05-16 11:15   ` [EXT] " S.j. Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2019-05-16 11:12 UTC (permalink / raw)
  To: S.j. Wang
  Cc: brian.austin, Paul.Handrigan, lgirdwood, perex, tiwai,
	alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

On Thu, May 16, 2019 at 11:09:27AM +0000, S.j. Wang wrote:

> > You also need a binding document update for this.
> ok, will send v3

Separate patch please, I already applied this and binding docs should be
separate patches anyway.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* RE: [EXT] Re: [PATCH V2] ASoC: cs42xx8: Add reset gpio handling
  2019-05-16 11:12 ` Mark Brown
@ 2019-05-16 11:15   ` S.j. Wang
  0 siblings, 0 replies; 3+ messages in thread
From: S.j. Wang @ 2019-05-16 11:15 UTC (permalink / raw)
  To: Mark Brown
  Cc: brian.austin, Paul.Handrigan, lgirdwood, perex, tiwai,
	alsa-devel, linux-kernel


Hi
> 
> On Thu, May 16, 2019 at 11:09:27AM +0000, S.j. Wang wrote:
> 
> > > You also need a binding document update for this.
> > ok, will send v3
> 
> Separate patch please, I already applied this and binding docs should be
> separate patches anyway.
Ok, I already send v3.  please forget the v3,  I will resend v3 for binding doc only.

Best regards
Wang shengjiu

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-16 11:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 11:09 [PATCH V2] ASoC: cs42xx8: Add reset gpio handling S.j. Wang
2019-05-16 11:12 ` Mark Brown
2019-05-16 11:15   ` [EXT] " S.j. Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).