LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Peng Fan <peng.fan@nxp.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"sboyd@kernel.org" <sboyd@kernel.org>
Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	Abel Vesa <abel.vesa@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Anson Huang <anson.huang@nxp.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	"aford173@gmail.com" <aford173@gmail.com>,
	Jacky Bai <ping.bai@nxp.com>, Jun Li <jun.li@nxp.com>,
	"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
	"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
	"agx@sigxcpu.org" <agx@sigxcpu.org>,
	"angus@akkea.ca" <angus@akkea.ca>,
	"heiko@sntech.de" <heiko@sntech.de>,
	Andy Duan <fugang.duan@nxp.com>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH V2 00/10] clk: imx: fixes and improve for i.MX8M
Date: Fri, 24 Apr 2020 19:30:16 +0000	[thread overview]
Message-ID: <VI1PR04MB6941A5E995F36689CB2A098DEED00@VI1PR04MB6941.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DB6PR0402MB27608E9A3D273DCFF6D90AE888D60@DB6PR0402MB2760.eurprd04.prod.outlook.com>

On 2020-04-18 4:45 PM, Peng Fan wrote:
>> Subject: [PATCH V2 00/10] clk: imx: fixes and improve for i.MX8M
> 
> Ping...
> 
> Thanks,
> Peng.
> 
>>
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Patches based on for-next
>>
>> V2:
>>   Patch 7, drop wait after write, add one line comment for write twice
>>
>> V1:
>> Patch 1,2 is to fix the lockdep warning reported by Leonard Patch 3 is to fix pll
>> mux bit Patch 4 is align with other i.MX8M using gate Patch 5 is to simplify
>> i.MX8MP clk root using composite
>>
>> Patch 3~5 is actually https://patchwork.kernel.org/patch/11402761/
>> with a minimal change to patch 5 here.
>>
>> Patch 6 is to use composite core clk for A53 clk root Patch 7,8,9 is actually to
>> fix CORE/BUS clk slice issue.
>>   This issue is triggerred after we update U-Boot to include  the A53 clk fixes
>> to sources from PLL, not from A53 root clk,  because of the signoff timing is
>> 1GHz. U-Boot set the A53 root  mux to 2, sys pll2 500MHz. Kernel will set
>> the A53 root mux to  4, sys pll1 800MHz, then gate off sys pll2 500MHz. Then
>> kernel  will gate off A53 root because clk_ignore_unsed, A53 directly sources
>> PLL, so it is ok to gate off A53 root. However when gate off A53  root clk,
>> system hang, because the original mux sys pll2 500MHz  gated off with
>> CLK_OPS_PARENT_ENABLE flag.
>>
>>   It is lucky that we not met issue for other core/bus clk slice  except A53
>> ROOT core slice. But it is always triggerred after  U-Boot and Linux both
>> switch to use ARM PLL for A53 core, but  have different mux settings for A53
>> root clk slice.
>>
>>   So the three patches is to address this issue.
>>
>> Patch 10 is make memrepair as critical.
>>
>> Peng Fan (10):
>>    arm64: dts: imx8m: assign clocks for A53
>>    clk: imx8m: drop clk_hw_set_parent for A53
>>    clk: imx: imx8mp: fix pll mux bit
>>    clk: imx8mp: Define gates for pll1/2 fixed dividers
>>    clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code
>>    clk: imx8m: migrate A53 clk root to use composite core
>>    clk: imx: add mux ops for i.MX8M composite clk
>>    clk: imx: add imx8m_clk_hw_composite_bus
>>    clk: imx: use imx8m_clk_hw_composite_bus for i.MX8M bus clk slice
>>    clk: imx8mp: mark memrepair clock as critical
>>
>>   arch/arm64/boot/dts/freescale/imx8mm.dtsi |  10 +-
>> arch/arm64/boot/dts/freescale/imx8mn.dtsi |  10 +-
>> arch/arm64/boot/dts/freescale/imx8mp.dtsi |  11 ++-
>>   arch/arm64/boot/dts/freescale/imx8mq.dtsi |   9 +-
>>   drivers/clk/imx/clk-composite-8m.c        |  67 ++++++++++++-
>>   drivers/clk/imx/clk-imx8mm.c              |  27 +++---
>>   drivers/clk/imx/clk-imx8mn.c              |  25 +++--
>>   drivers/clk/imx/clk-imx8mp.c              | 150
>> +++++++++++++++---------------
>>   drivers/clk/imx/clk-imx8mq.c              |  29 +++---
>>   drivers/clk/imx/clk.h                     |   7 ++
>>   include/dt-bindings/clock/imx8mp-clock.h  |  28 +++++-
>>   11 files changed, 240 insertions(+), 133 deletions(-)

For 1-6 and 10:

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>

      reply	other threads:[~2020-04-24 19:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 10:19 peng.fan
2020-03-12 10:19 ` [PATCH V2 01/10] arm64: dts: imx8m: assign clocks for A53 peng.fan
2020-04-26  3:51   ` Aisheng Dong
2020-03-12 10:19 ` [PATCH V2 02/10] clk: imx8m: drop clk_hw_set_parent " peng.fan
2020-04-26  3:54   ` Aisheng Dong
2020-03-12 10:19 ` [PATCH V2 03/10] clk: imx: imx8mp: fix pll mux bit peng.fan
2020-04-26  4:23   ` Aisheng Dong
2020-03-12 10:19 ` [PATCH V2 04/10] clk: imx8mp: Define gates for pll1/2 fixed dividers peng.fan
2020-04-26  4:29   ` Aisheng Dong
2020-03-12 10:19 ` [PATCH V2 05/10] clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code peng.fan
2020-04-26  4:38   ` Aisheng Dong
2020-04-27  8:57     ` Peng Fan
2020-03-12 10:19 ` [PATCH V2 06/10] clk: imx8m: migrate A53 clk root to use composite core peng.fan
2020-04-26  4:43   ` Aisheng Dong
2020-04-27  8:58     ` Peng Fan
2020-03-12 10:19 ` [PATCH V2 07/10] clk: imx: add mux ops for i.MX8M composite clk peng.fan
2020-04-24 19:29   ` Leonard Crestez
2020-04-27  9:15     ` Peng Fan
2020-04-27 19:34       ` Leonard Crestez
2020-04-28  1:08         ` Peng Fan
2020-04-26  5:08   ` Aisheng Dong
2020-04-27  9:11     ` Peng Fan
2020-04-30 10:00       ` Abel Vesa
2020-04-30 12:56         ` Peng Fan
2020-03-12 10:19 ` [PATCH V2 08/10] clk: imx: add imx8m_clk_hw_composite_bus peng.fan
2020-03-12 10:19 ` [PATCH V2 09/10] clk: imx: use imx8m_clk_hw_composite_bus for i.MX8M bus clk slice peng.fan
2020-03-12 10:19 ` [PATCH V2 10/10] clk: imx8mp: mark memrepair clock as critical peng.fan
2020-03-19 10:04 ` [PATCH V2 00/10] clk: imx: fixes and improve for i.MX8M Peng Fan
2020-04-18 13:45 ` Peng Fan
2020-04-24 19:30   ` Leonard Crestez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB6941A5E995F36689CB2A098DEED00@VI1PR04MB6941.eurprd04.prod.outlook.com \
    --to=leonard.crestez@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=aford173@gmail.com \
    --cc=agx@sigxcpu.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=angus@akkea.ca \
    --cc=anson.huang@nxp.com \
    --cc=daniel.baluta@nxp.com \
    --cc=festevam@gmail.com \
    --cc=fugang.duan@nxp.com \
    --cc=heiko@sntech.de \
    --cc=jun.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --subject='Re: [PATCH V2 00/10] clk: imx: fixes and improve for i.MX8M' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).