LKML Archive on
 help / color / Atom feed
From: "Ahmed S. Darwish" <>
To: John Garry <>
Subject: Re: [PATCH] scsi: libsas and users: Remove notifier indirection
Date: Tue, 12 Jan 2021 12:25:01 +0100
Message-ID: <X/2HDUmb8L8LPELG@lx-t490> (raw)
In-Reply-To: <>

Hi John,

On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote:
> LLDDs report events to libsas with .notify_port_event and
> .notify_phy_event callbacks.
> These callbacks are fixed and so there is no reason why the functions
> cannot be called directly, so do that.
> This neatens the code slightly, makes it more obvious, and reduces
> function pointer usage, which is generally a good thing. Downside is that
> there are 2x more symbol exports.
> Signed-off-by: John Garry <>

Since this patch necessitates a careful manual rebase of _every_ patch
in my series, I've included it at the top of my v2 submission and
rebased everything on top:

Some left-over 'sas_ha' local variables were removed, and I've mentioned
that in the commit log of course.


Ahmed S. Darwish
Linutronix GmbH

  parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 17:28 John Garry
2021-01-11 17:41 ` Ahmed S. Darwish
2021-01-11 17:44   ` John Garry
2021-01-11 17:52     ` Ahmed S. Darwish
2021-01-11 19:49 ` kernel test robot
2021-01-12 11:25 ` Ahmed S. Darwish [this message]
2021-01-12 11:27   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/2HDUmb8L8LPELG@lx-t490 \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone