From: "Ahmed S. Darwish" <a.darwish@linutronix.de> To: John Garry <john.garry@huawei.com> Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, artur.paszkiewicz@intel.com, jinpu.wang@cloud.ionos.com, corbet@lwn.net, yanaijie@huawei.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, intel-linux-scu@intel.com, linux-doc@vger.kernel.org Subject: Re: [PATCH] scsi: libsas and users: Remove notifier indirection Date: Mon, 11 Jan 2021 18:52:06 +0100 Message-ID: <X/yQRg4duKpDjFFC@lx-t490> (raw) In-Reply-To: <a056f28e-bbdc-1400-83f2-b6d76afd92b9@huawei.com> On Mon, Jan 11, 2021 at 05:44:17PM +0000, John Garry wrote: > On 11/01/2021 17:41, Ahmed S. Darwish wrote: > > On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote: > > ... > > > index a920eced92ec..6a51abdc59ae 100644 > > > --- a/drivers/scsi/mvsas/mv_sas.c > > > +++ b/drivers/scsi/mvsas/mv_sas.c > > > @@ -230,7 +230,7 @@ static void mvs_bytes_dmaed(struct mvs_info *mvi, int i) > > > } > > > > > > sas_ha = mvi->sas; > > > - sas_ha->notify_phy_event(sas_phy, PHYE_OOB_DONE); > > > + sas_notify_phy_event(sas_phy, PHYE_OOB_DONE); > > > > > > > Minor point: "sas_ha" is now not used anywhere; it should be removed. > > . > > > > ah, yes, it can be removed. > Similarly for drivers/scsi/pm8001/pm8001_sas.c. (Just discovering these while integrating your patch at the top of my series). > BTW, on separate topic, did intel-linux-scu@intel.com bounce for you? > Yup :) -- Ahmed S. Darwish Linutronix GmbH
next prev parent reply index Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-11 17:28 John Garry 2021-01-11 17:41 ` Ahmed S. Darwish 2021-01-11 17:44 ` John Garry 2021-01-11 17:52 ` Ahmed S. Darwish [this message] 2021-01-11 19:49 ` kernel test robot 2021-01-12 11:25 ` Ahmed S. Darwish 2021-01-12 11:27 ` John Garry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X/yQRg4duKpDjFFC@lx-t490 \ --to=a.darwish@linutronix.de \ --cc=artur.paszkiewicz@intel.com \ --cc=corbet@lwn.net \ --cc=intel-linux-scu@intel.com \ --cc=jejb@linux.ibm.com \ --cc=jinpu.wang@cloud.ionos.com \ --cc=john.garry@huawei.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=yanaijie@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git