From: "Ahmed S. Darwish" <a.darwish@linutronix.de> To: Finn Thain <fthain@telegraphics.com.au> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Michael Schmitz <schmitzmic@gmail.com>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Thomas Gleixner <tglx@linutronix.de>, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi/NCR5380: Remove in_interrupt() test Date: Fri, 4 Dec 2020 17:08:47 +0100 Message-ID: <X8pfD5XtLoOygdez@lx-t490> (raw) In-Reply-To: <alpine.LNX.2.23.453.2012040953030.6@nippy.intranet> On Fri, Dec 04, 2020 at 10:08:08AM +1100, Finn Thain wrote: ... > > You've put your finger on a known problem with certain > NCR5380_poll_politely() call sites. That is, the nominal timeout, HZ / 64, > is meaningless because it is ignored in atomic context. So you may as well > specify 0 jiffies at these call sites. (There will be a 1 jiffy timeout > applied regardless.) ... > > However, I can see the value in your approach, i.e. passing a zero timeout > to NCR5380_poll_politely() whenever that argument is unused. And I agree > that this could then be used to inhibit sleeping, rather than testing > irqs_disabled(). > > So if you really don't like irqs_disabled(), perhaps you can just keep the > better parts of your two attempts, i.e. passing 0 to > NCR5380_poll_politely() where appropriate and facilitating that by adding > a new can_sleep parameter to do_abort() and NCR5380_transfer_pio(), as in, ... > > Does that sound like a reasonable compromise? > Yes, of course. Thanks a lot. I've sent a v2. -- Ahmed S. Darwish Linutronix GmbH
next prev parent reply index Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-01 6:46 Finn Thain 2020-12-01 17:05 ` Sebastian Andrzej Siewior 2020-12-03 23:08 ` Finn Thain 2020-12-04 8:38 ` Geert Uytterhoeven 2020-12-04 16:08 ` Ahmed S. Darwish [this message] 2020-12-01 18:01 ` Michael Schmitz 2020-12-04 15:32 ` [PATCH v2] scsi: NCR5380: Remove context check Ahmed S. Darwish 2020-12-05 4:28 ` Finn Thain 2020-12-06 7:51 ` [PATCH v3] " Ahmed S. Darwish 2020-12-08 0:12 ` Finn Thain 2020-12-08 1:26 ` Martin K. Petersen 2020-12-09 17:23 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X8pfD5XtLoOygdez@lx-t490 \ --to=a.darwish@linutronix.de \ --cc=bigeasy@linutronix.de \ --cc=fthain@telegraphics.com.au \ --cc=jejb@linux.ibm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=schmitzmic@gmail.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git