LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] make secmark_tg_destroy() static
@ 2008-02-13 21:29 Adrian Bunk
2008-02-13 21:34 ` Paul Moore
2008-02-14 1:41 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Adrian Bunk @ 2008-02-13 21:29 UTC (permalink / raw)
To: Paul Moore, James Morris, coreteam; +Cc: linux-kernel
This patch makes the needlessly global secmark_tg_destroy() static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
df66d8d74309b41298ae011532fd284aad3ed2ba
diff --git a/net/netfilter/xt_SECMARK.c b/net/netfilter/xt_SECMARK.c
index 7708e20..c028485 100644
--- a/net/netfilter/xt_SECMARK.c
+++ b/net/netfilter/xt_SECMARK.c
@@ -111,7 +111,7 @@ secmark_tg_check(const char *tablename, const void *entry,
return true;
}
-void secmark_tg_destroy(const struct xt_target *target, void *targinfo)
+static void secmark_tg_destroy(const struct xt_target *target, void *targinfo)
{
switch (mode) {
case SECMARK_MODE_SEL:
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] make secmark_tg_destroy() static
2008-02-13 21:29 [2.6 patch] make secmark_tg_destroy() static Adrian Bunk
@ 2008-02-13 21:34 ` Paul Moore
2008-02-13 23:41 ` James Morris
2008-02-14 1:41 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Paul Moore @ 2008-02-13 21:34 UTC (permalink / raw)
To: Adrian Bunk; +Cc: James Morris, coreteam, linux-kernel
On Wednesday 13 February 2008 4:29:40 pm Adrian Bunk wrote:
> This patch makes the needlessly global secmark_tg_destroy() static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Thanks for catching this.
Acked-by: Paul Moore <paul.moore@hp.com>
> ---
> df66d8d74309b41298ae011532fd284aad3ed2ba
> diff --git a/net/netfilter/xt_SECMARK.c b/net/netfilter/xt_SECMARK.c
> index 7708e20..c028485 100644
> --- a/net/netfilter/xt_SECMARK.c
> +++ b/net/netfilter/xt_SECMARK.c
> @@ -111,7 +111,7 @@ secmark_tg_check(const char *tablename, const
> void *entry, return true;
> }
>
> -void secmark_tg_destroy(const struct xt_target *target, void
> *targinfo) +static void secmark_tg_destroy(const struct xt_target
> *target, void *targinfo) {
> switch (mode) {
> case SECMARK_MODE_SEL:
--
paul moore
linux security @ hp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] make secmark_tg_destroy() static
2008-02-13 21:34 ` Paul Moore
@ 2008-02-13 23:41 ` James Morris
2008-02-14 5:56 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: James Morris @ 2008-02-13 23:41 UTC (permalink / raw)
To: Paul Moore; +Cc: Adrian Bunk, coreteam, linux-kernel
On Wed, 13 Feb 2008, Paul Moore wrote:
> On Wednesday 13 February 2008 4:29:40 pm Adrian Bunk wrote:
> > This patch makes the needlessly global secmark_tg_destroy() static.
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> Thanks for catching this.
>
> Acked-by: Paul Moore <paul.moore@hp.com>
>
Applied -- will push to Linus unless the netfilter folk do it first.
- James
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] make secmark_tg_destroy() static
2008-02-13 21:29 [2.6 patch] make secmark_tg_destroy() static Adrian Bunk
2008-02-13 21:34 ` Paul Moore
@ 2008-02-14 1:41 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2008-02-14 1:41 UTC (permalink / raw)
To: bunk; +Cc: paul.moore, jmorris, coreteam, linux-kernel
From: Adrian Bunk <bunk@kernel.org>
Date: Wed, 13 Feb 2008 23:29:40 +0200
> This patch makes the needlessly global secmark_tg_destroy() static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] make secmark_tg_destroy() static
2008-02-13 23:41 ` James Morris
@ 2008-02-14 5:56 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2008-02-14 5:56 UTC (permalink / raw)
To: jmorris; +Cc: paul.moore, bunk, coreteam, linux-kernel
From: James Morris <jmorris@namei.org>
Date: Thu, 14 Feb 2008 10:41:19 +1100 (EST)
> On Wed, 13 Feb 2008, Paul Moore wrote:
>
> > On Wednesday 13 February 2008 4:29:40 pm Adrian Bunk wrote:
> > > This patch makes the needlessly global secmark_tg_destroy() static.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > Thanks for catching this.
> >
> > Acked-by: Paul Moore <paul.moore@hp.com>
> >
>
> Applied -- will push to Linus unless the netfilter folk do it first.
I sucked it in, don't worry about it.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-02-14 5:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-13 21:29 [2.6 patch] make secmark_tg_destroy() static Adrian Bunk
2008-02-13 21:34 ` Paul Moore
2008-02-13 23:41 ` James Morris
2008-02-14 5:56 ` David Miller
2008-02-14 1:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).