From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4547C07E9B for ; Mon, 19 Jul 2021 12:45:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85C8860FF3 for ; Mon, 19 Jul 2021 12:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237004AbhGSMEU (ORCPT ); Mon, 19 Jul 2021 08:04:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236571AbhGSMET (ORCPT ); Mon, 19 Jul 2021 08:04:19 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 359C3C061574 for ; Mon, 19 Jul 2021 05:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tGkUUStChLCXt1Uh1220a9d3L35+2D4Hyrolq+19Nbc=; b=FesO4hgZXSGsqrTOY4GPu4RWOC xFyqdunUnk/ncfxgNVnYtdkBcOYownzTEQi5Kq1h7NqnJ9lRRtZc/KsLHP3Kl4BgF+vmVWjxP7MZv exMfmFqQ9fSstaNshZwpG3XayTQHDR8p0NlVQsA9F+5rzpSZsJF7/6kdgUXPcHS6zfnzA0eOtZEN1 ABaFWiBAXuEEEWgWahlL3FCEfPYBQg2vIobdIjp682bb7X99Z7hgH6n6rZeT40Erxuh9QFqhSgT0+ 8fUaTaz3BWRCN28WocOT3Q2LMF9uHbTZblywfZikEQn5l2pf+ny8LK3ifaCRV6cJKi7V+hYg/rGnT Jqgaks9Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5SdD-006r45-0z; Mon, 19 Jul 2021 12:44:32 +0000 Date: Mon, 19 Jul 2021 13:44:22 +0100 From: Matthew Wilcox To: Andy Shevchenko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v1 1/1] mm/util: Rephrase documentation for kmemdup_nul() to clarify input Message-ID: References: <20210719122002.41334-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719122002.41334-1-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 19, 2021 at 03:20:02PM +0300, Andy Shevchenko wrote: > kmemdup_nul() strictly speaking is not related to the string API, > while being quite useful for it. Rephrase documentation to make it > clear that input data can be anything (any data, which may contain > any bytes, including 0x00). That's not a useful thing to do, though. This rephrasing you've done is more confusing than the original.