LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC
@ 2021-06-07 23:35 Chris Blake
  2021-07-02 12:25 ` Chris
  2021-07-20 14:47 ` Lee Jones
  0 siblings, 2 replies; 4+ messages in thread
From: Chris Blake @ 2021-06-07 23:35 UTC (permalink / raw)
  To: ptyser, lee.jones, linux-kernel, chunkeey, linux-gpio; +Cc: Chris Blake

Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
blink support. However, blink support isn't supported by the GPIO
driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
MX100-HW.

Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
Co-developed-by: Christian Lamparter <chunkeey@gmail.com>
---

Changelog:
V3: Update commit message format and update contributor message.
V2: Updated commit message, and added Christian Lamparter as a
contributor.
V1: Initial Patch

 drivers/mfd/lpc_ich.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index 3bbb29a7e7a5..f10e53187f67 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -489,6 +489,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
 	[LPC_DH89XXCC] = {
 		.name = "DH89xxCC",
 		.iTCO_version = 2,
+		.gpio_version = ICH_V5_GPIO,
 	},
 	[LPC_PPT] = {
 		.name = "Panther Point",
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC
  2021-06-07 23:35 [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC Chris Blake
@ 2021-07-02 12:25 ` Chris
  2021-07-02 12:45   ` Lee Jones
  2021-07-20 14:47 ` Lee Jones
  1 sibling, 1 reply; 4+ messages in thread
From: Chris @ 2021-07-02 12:25 UTC (permalink / raw)
  To: ptyser, Lee Jones, linux-kernel, Christian Lamparter, linux-gpio

On Mon, Jun 7, 2021 at 6:35 PM Chris Blake <chrisrblake93@gmail.com> wrote:
>
> Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> blink support. However, blink support isn't supported by the GPIO
> driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> MX100-HW.
>
> Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> Co-developed-by: Christian Lamparter <chunkeey@gmail.com>
> ---
>
> Changelog:
> V3: Update commit message format and update contributor message.
> V2: Updated commit message, and added Christian Lamparter as a
> contributor.
> V1: Initial Patch
>
>  drivers/mfd/lpc_ich.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> index 3bbb29a7e7a5..f10e53187f67 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich.c
> @@ -489,6 +489,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
>         [LPC_DH89XXCC] = {
>                 .name = "DH89xxCC",
>                 .iTCO_version = 2,
> +               .gpio_version = ICH_V5_GPIO,
>         },
>         [LPC_PPT] = {
>                 .name = "Panther Point",
> --
> 2.25.1
>

Hello,

Just curious if there's anything I can do to help get this reviewed
for merge, thanks.

Regards,
Chris B

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC
  2021-07-02 12:25 ` Chris
@ 2021-07-02 12:45   ` Lee Jones
  0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2021-07-02 12:45 UTC (permalink / raw)
  To: Chris; +Cc: ptyser, linux-kernel, Christian Lamparter, linux-gpio

On Fri, 02 Jul 2021, Chris wrote:

> On Mon, Jun 7, 2021 at 6:35 PM Chris Blake <chrisrblake93@gmail.com> wrote:
> >
> > Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> > is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> > blink support. However, blink support isn't supported by the GPIO
> > driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> > MX100-HW.
> >
> > Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> > Co-developed-by: Christian Lamparter <chunkeey@gmail.com>
> > ---
> >
> > Changelog:
> > V3: Update commit message format and update contributor message.
> > V2: Updated commit message, and added Christian Lamparter as a
> > contributor.
> > V1: Initial Patch
> >
> >  drivers/mfd/lpc_ich.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> > index 3bbb29a7e7a5..f10e53187f67 100644
> > --- a/drivers/mfd/lpc_ich.c
> > +++ b/drivers/mfd/lpc_ich.c
> > @@ -489,6 +489,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
> >         [LPC_DH89XXCC] = {
> >                 .name = "DH89xxCC",
> >                 .iTCO_version = 2,
> > +               .gpio_version = ICH_V5_GPIO,
> >         },
> >         [LPC_PPT] = {
> >                 .name = "Panther Point",
> >
> 
> Hello,
> 
> Just curious if there's anything I can do to help get this reviewed
> for merge, thanks.

Apologies, this had slipped through the gaps.

Looks simple enough.  I'll review it for v5.15 once -rc1 is out.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC
  2021-06-07 23:35 [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC Chris Blake
  2021-07-02 12:25 ` Chris
@ 2021-07-20 14:47 ` Lee Jones
  1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2021-07-20 14:47 UTC (permalink / raw)
  To: Chris Blake; +Cc: ptyser, linux-kernel, chunkeey, linux-gpio

On Mon, 07 Jun 2021, Chris Blake wrote:

> Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> blink support. However, blink support isn't supported by the GPIO
> driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> MX100-HW.
> 
> Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> Co-developed-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> 
> Changelog:
> V3: Update commit message format and update contributor message.
> V2: Updated commit message, and added Christian Lamparter as a
> contributor.
> V1: Initial Patch
> 
>  drivers/mfd/lpc_ich.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-20 15:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07 23:35 [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC Chris Blake
2021-07-02 12:25 ` Chris
2021-07-02 12:45   ` Lee Jones
2021-07-20 14:47 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).