LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static
@ 2021-08-08  6:33 Wei Yongjun
  2021-08-08 13:19 ` Gao Xiang
  0 siblings, 1 reply; 5+ messages in thread
From: Wei Yongjun @ 2021-08-08  6:33 UTC (permalink / raw)
  To: weiyongjun1, Huang Jianan, Gao Xiang, Chao Yu
  Cc: linux-erofs, linux-kernel, kernel-janitors, Hulk Robot

The sparse tool complains as follows:

fs/erofs/data.c:150:24: warning:
 symbol 'erofs_iomap_ops' was not declared. Should it be static?

This symbol is not used outside of data.c, so marks it static.

Fixes: 3e9ce908c114 ("erofs: iomap support for non-tailpacking DIO")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 fs/erofs/data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 4ea10b31790c..b2a22aabc9bc 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -147,7 +147,7 @@ static int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t length,
 	return written;
 }
 
-const struct iomap_ops erofs_iomap_ops = {
+static const struct iomap_ops erofs_iomap_ops = {
 	.iomap_begin = erofs_iomap_begin,
 	.iomap_end = erofs_iomap_end,
 };


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-09  3:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-08  6:33 [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static Wei Yongjun
2021-08-08 13:19 ` Gao Xiang
2021-08-08 23:56   ` Chao Yu
2021-08-09  2:49     ` weiyongjun (A)
2021-08-09  3:06       ` Gao Xiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).