LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] dmaengine: acpi: Check for errors from acpi_register_gsi() separately
Date: Fri, 6 Aug 2021 19:14:50 +0530	[thread overview]
Message-ID: <YQ080pMpNcXqt1ml@matsya> (raw)
In-Reply-To: <20210802175532.54311-1-andriy.shevchenko@linux.intel.com>

On 02-08-21, 20:55, Andy Shevchenko wrote:
> While IRQ test agaist the returned variable in practice is a good enough
> there is still a room for theoretical mistake in case the vIRQ of the
> device contains the same error code that acpi_register_gsi() may return.
> Due to this, check for error code separately from matching the vIRQs.
> 
> Besides that, append documentation to tell why acpi_gsi_to_irq() can't
> be used and we call acpi_register_gsi() instead.

patch fails to apply, pls rebase

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/dma/acpi-dma.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/acpi-dma.c b/drivers/dma/acpi-dma.c
> index 52768dc8ce12..5906eae26e2a 100644
> --- a/drivers/dma/acpi-dma.c
> +++ b/drivers/dma/acpi-dma.c
> @@ -75,8 +75,16 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp,
>  	    si->mmio_base_high != upper_32_bits(mem))
>  		return 0;
>  
> -	/* Match device by Linux vIRQ */
> +	/*
> +	 * acpi_gsi_to_irq() can't be used because some platforms do not save
> +	 * registered IRQs in the MP table. Instead we just try to register
> +	 * the GSI, which is the core part of the above mentioned function.
> +	 */
>  	ret = acpi_register_gsi(NULL, si->gsi_interrupt, si->interrupt_mode, si->interrupt_polarity);
> +	if (ret < 0)
> +		return 0;
> +
> +	/* Match device by Linux vIRQ */
>  	if (ret != irq)
>  		return 0;
>  
> -- 
> 2.30.2

-- 
~Vinod

  reply	other threads:[~2021-08-06 13:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 17:55 Andy Shevchenko
2021-08-06 13:44 ` Vinod Koul [this message]
2021-08-06 15:29   ` Andy Shevchenko
2021-08-06 16:19     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQ080pMpNcXqt1ml@matsya \
    --to=vkoul@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v1 1/1] dmaengine: acpi: Check for errors from acpi_register_gsi() separately' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).