LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: psodagud@codeaurora.org
Cc: rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM: sleep: core: Avoid setting power.must_resume to false
Date: Fri, 6 Aug 2021 17:16:21 +0200	[thread overview]
Message-ID: <YQ1SRbBrcKl2Vt9f@kroah.com> (raw)
In-Reply-To: <0fe9a873ca77293151a61f64d355895f@codeaurora.org>

On Fri, Aug 06, 2021 at 08:07:08AM -0700, psodagud@codeaurora.org wrote:
> On 2021-08-03 10:16, Greg KH wrote:
> > On Mon, Jul 26, 2021 at 08:24:34AM -0700, Prasad Sodagudi wrote:
> > > There are variables(power.may_skip_resume and dev->power.must_resume)
> > > and DPM_FLAG_MAY_SKIP_RESUME flags to control the resume of devices
> > > after
> > > a system wide suspend transition.
> > > 
> > > Setting the DPM_FLAG_MAY_SKIP_RESUME flag means that the driver allows
> > > its "noirq" and "early" resume callbacks to be skipped if the device
> > > can be left in suspend after a system-wide transition into the working
> > > state. PM core determines that the driver's "noirq" and "early" resume
> > > callbacks should be skipped or not with dev_pm_skip_resume()
> > > function by
> > > checking power.may_skip_resume variable.
> > > 
> > > power.must_resume variable is getting set to false in
> > > __device_suspend()
> > > function without checking device's DPM_FLAG_MAY_SKIP_RESUME and
> > > dev->power.usage_count variables. This is leading to failure to call
> > > resume handler for some of the devices suspended in early suspend
> > > phase.
> > > So check device's DPM_FLAG_MAY_SKIP_RESUME flag before
> > > setting power.must_resume variable.
> > > 
> > > Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
> > > ---
> > >  drivers/base/power/main.c | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> > > index d568772..8eebc4d 100644
> > > --- a/drivers/base/power/main.c
> > > +++ b/drivers/base/power/main.c
> > > @@ -1642,7 +1642,11 @@ static int __device_suspend(struct device
> > > *dev, pm_message_t state, bool async)
> > >  	}
> > > 
> > >  	dev->power.may_skip_resume = true;
> > > -	dev->power.must_resume = false;
> > > +	if ((atomic_read(&dev->power.usage_count) <= 1) &&
> > > +			(dev_pm_test_driver_flags(dev, DPM_FLAG_MAY_SKIP_RESUME)))
> > 
> > What is preventing that atomic value from changing _right_ after you
> > just read this?
> > 
> > and very odd indentation, checkpatch didn't complain about this?
> Sure. I will fix indentation problem once Rafael reviewed this patch.

Neither of us can take this as-is, so why wait?


  reply	other threads:[~2021-08-06 15:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 15:24 Prasad Sodagudi
2021-08-03 17:16 ` Greg KH
2021-08-06 15:07   ` psodagud
2021-08-06 15:16     ` Greg KH [this message]
2021-08-07  6:00     ` Greg KH
2021-08-08 16:10       ` [PATCH v2] " Prasad Sodagudi
2021-08-08 17:36         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQ1SRbBrcKl2Vt9f@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=psodagud@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    --subject='Re: [PATCH] PM: sleep: core: Avoid setting power.must_resume to false' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).