LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] dmaengine: acpi: Check for errors from acpi_register_gsi() separately
Date: Fri, 6 Aug 2021 21:49:34 +0530	[thread overview]
Message-ID: <YQ1hFtHRDIflENis@matsya> (raw)
In-Reply-To: <YQ1VU/lHIXFtjwVE@smile.fi.intel.com>

On 06-08-21, 18:29, Andy Shevchenko wrote:
> On Fri, Aug 06, 2021 at 07:14:50PM +0530, Vinod Koul wrote:
> > On 02-08-21, 20:55, Andy Shevchenko wrote:
> > > While IRQ test agaist the returned variable in practice is a good enough
> > > there is still a room for theoretical mistake in case the vIRQ of the
> > > device contains the same error code that acpi_register_gsi() may return.
> > > Due to this, check for error code separately from matching the vIRQs.
> > > 
> > > Besides that, append documentation to tell why acpi_gsi_to_irq() can't
> > > be used and we call acpi_register_gsi() instead.
> > 
> > patch fails to apply, pls rebase
> 
> I don't see that you applied the previous patch [1].
> Care to apply it, please?

Sorry, somehow that one was pushed to queue but never got applied!

Have applied both now

> 
> [1]: https://lore.kernel.org/dmaengine/20210730202715.24375-1-andriy.shevchenko@linux.intel.com/T/#u
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 

-- 
~Vinod

      reply	other threads:[~2021-08-06 16:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 17:55 Andy Shevchenko
2021-08-06 13:44 ` Vinod Koul
2021-08-06 15:29   ` Andy Shevchenko
2021-08-06 16:19     ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQ1hFtHRDIflENis@matsya \
    --to=vkoul@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v1 1/1] dmaengine: acpi: Check for errors from acpi_register_gsi() separately' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).