LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] slimbus: patches (set 1) for 5.15
Date: Sat, 7 Aug 2021 16:16:50 +0200	[thread overview]
Message-ID: <YQ6V0oPrLDTNo6cb@kroah.com> (raw)
In-Reply-To: <97b911ff-3fd6-45eb-81ec-01971e4c2741@linaro.org>

On Sat, Aug 07, 2021 at 02:26:11PM +0100, Srinivas Kandagatla wrote:
> 
> 
> On 07/08/2021 14:08, Greg KH wrote:
> > On Sat, Aug 07, 2021 at 02:04:39PM +0100, Srinivas Kandagatla wrote:
> > > 
> > > 
> > > On 07/08/2021 14:01, Greg KH wrote:
> > > > On Sat, Aug 07, 2021 at 11:48:48AM +0100, Srinivas Kandagatla wrote:
> > > > > 
> > > > > 
> > > > > On 06/08/2021 14:20, Greg KH wrote:
> > > > > > On Fri, Aug 06, 2021 at 10:16:35AM +0100, Srinivas Kandagatla wrote:
> > > > > > > Hi Greg,
> > > > > > > 
> > > > > > > Recently runtime pm testing on slimbus reveled that its
> > > > > > > totally broken on SlimBus ngd drivers.
> > > > > > > 
> > > > > > > Below are the fixes to get it back working.
> > > > > > > 
> > > > > > > - One of the reason begin incorrect device pointer used for
> > > > > > > runtime pm and in some places
> > > > > > > 
> > > > > > > - Second one was to do with unable to validate transaction id
> > > > > > >     which resulted in negative runtime pm count.
> > > > > > > 
> > > > > > > - Other fix was to do with resetting dma addresses once ngd
> > > > > > > controller is power-cycled.
> > > > > > > 
> > > > > > > With all these fixed runtime pm is now fully functional on NGD
> > > > > > > controllers.
> > > > > > > 
> > > > > > > Currently I marked them all with Cc: <stable@vger.kernel.org>
> > > > > > > as these all patches are required to fix runtime pm on SlimBus
> > > > > > > NGD controller.
> > > > > > > 
> > > > > > > Can you please queue them up for 5.15.
> > > > > > 
> > > > > > Why do you want these for 5.15-rc1 when you need them to fix problems in
> > > > > > 5.14?  Shouldn't they go into 5.14-final?
> > > > > 
> > > > > Yes, these should go to other stable trees aswell.
> > > > > I assumed that Fixes tag will automatically backport those patches.
> > > > 
> > > > Yes, but that can not happen until they hit Linus's tree, which would
> > > > not be until 5.15-rc1.  Do you want to delay until that long from now?
> > > > 
> > > > How about splitting this into 2 patch series, one that you want to see
> > > > get into 5.14-final, and one for 5.15-rc1.
> > > 
> > > All the patches in these series are fixes so the can go to 5.14-final.
> > 
> > Then why did you say originally that you wanted them in 5.15?
> 
> TBH, I tend to send out SlimBus and nvmem patches only once around rc5-rc6
> time which also includes some minor fixes, and you normally apply them for
> next rc1 release.
> 
> In this particular case I should have explicitly said to pick them up for
> 5.14 next rc.
> 
> Do you want me to resend them with proper cover letter? or are you okay to
> take them as they are?

Yes, please resend the series, for some reason I didn't think the first
one needed to go to 5.14-final, but I might have been thinking of a
different patch series...

thanks,

greg k-h

      reply	other threads:[~2021-08-07 14:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06  9:16 Srinivas Kandagatla
2021-08-06  9:16 ` [PATCH 1/4] slimbus: messaging: start transaction ids from 1 instead of zero Srinivas Kandagatla
2021-08-06  9:16 ` [PATCH 2/4] slimbus: messaging: check for valid transaction id Srinivas Kandagatla
2021-08-06  9:16 ` [PATCH 3/4] slimbus: ngd: set correct device for pm Srinivas Kandagatla
2021-08-06  9:16 ` [PATCH 4/4] slimbus: ngd: reset dma setup during runtime pm Srinivas Kandagatla
2021-08-06 13:20 ` [PATCH 0/4] slimbus: patches (set 1) for 5.15 Greg KH
2021-08-07 10:48   ` Srinivas Kandagatla
2021-08-07 13:01     ` Greg KH
2021-08-07 13:04       ` Srinivas Kandagatla
2021-08-07 13:08         ` Greg KH
2021-08-07 13:26           ` Srinivas Kandagatla
2021-08-07 14:16             ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQ6V0oPrLDTNo6cb@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --subject='Re: [PATCH 0/4] slimbus: patches (set 1) for 5.15' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).