LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "qiaoyanbo_310@163.com" <qiaoyanbo_310@163.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] kobject: kobject_add_internal cleanup
Date: Fri, 30 Jul 2021 15:37:21 +0200	[thread overview]
Message-ID: <YQQAkfGXjdDc/3na@kroah.com> (raw)
In-Reply-To: <YQP04FoSecPhI+38@ybqiao-virtual-machine>

On Fri, Jul 30, 2021 at 08:47:28PM +0800, qiaoyanbo_310@163.com wrote:
> On Fri, Jul 30, 2021 at 06:48:23AM +0200, Greg KH wrote:
> > On Fri, Jul 30, 2021 at 12:44:26AM +0800, qiaoyanbo_310 wrote:
> > > Hi Greg KH,
> > 
> > Sorry, but html email is rejected by the mailing lists.  Please try
> > again after fixing up your email client, and I will be glad to respond.
> > 
> > thanks,
> > 
> > greg k-h
> 
> (Sorry, this is the first time I use the mutt environment to send mail,
> 	shamed on me I know~)
> 
> >Why is this a problem?  What bug is this solving?  Is the code somehow
> >now faster or smaller that can be measured? 
> 
> I don't think the logic of the original code is self consistent.

I no longer even remember what the patch was anymore here, sorry.
That's the problem when emails are not quoted properly :(

> This is not a bug,  but it causes  some unnecessary assignment operations.

Are you sure?  What would set the kobject parent to NULL then?

> This patch is to clean unnecessary assignment operations.

Are you sure there is anything unneeded?  Have you measured the
performance issues here?  What benchmark is affected by this?

thanks,

greg k-h

      reply	other threads:[~2021-07-30 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 14:32 Qiao Yanbo
2021-07-28 10:10 ` Greg KH
     [not found]   ` <3be7ce57.62f6.17af280a47f.Coremail.qiaoyanbo_310@163.com>
2021-07-29 13:59     ` Greg KH
     [not found]       ` <54cc7e43.808a.17af32725d9.Coremail.qiaoyanbo_310@163.com>
2021-07-30  4:48         ` Greg KH
2021-07-30 12:47           ` qiaoyanbo_310
2021-07-30 13:37             ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQQAkfGXjdDc/3na@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qiaoyanbo_310@163.com \
    --cc=rafael@kernel.org \
    --subject='Re: Re: [PATCH] kobject: kobject_add_internal cleanup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).