LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Tinghan Shen <tinghan.shen@mediatek.com>
Cc: ohad@wizery.com, mathieu.poirier@linaro.org, robh+dt@kernel.org,
	matthias.bgg@gmail.com, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	srv_heupstream@mediatek.com, tzungbi@google.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v4 4/4] remoteproc: mediatek: Support mt8195 scp
Date: Fri, 30 Jul 2021 10:58:06 -0500	[thread overview]
Message-ID: <YQQhjuqAaT1xaIWM@builder.lan> (raw)
In-Reply-To: <20210728035859.5405-5-tinghan.shen@mediatek.com>

On Tue 27 Jul 22:58 CDT 2021, Tinghan Shen wrote:

> The SCP clock design is changed on mt8195 that doesn't need to control
> SCP clock on kernel side.
> 
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
>  drivers/remoteproc/mtk_scp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index 9679cc26895e..250cb946ea37 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -785,7 +785,7 @@ static int scp_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto destroy_mutex;
>  
> -	scp->clk = devm_clk_get(dev, "main");
> +	scp->clk = devm_clk_get_optional(dev, "main");

This makes the clock optional for mt8183 and mt8192 as well.

How about using mtk_scp_of_data to denote if the clock should be
acquired?

Regards,
Bjorn

>  	if (IS_ERR(scp->clk)) {
>  		dev_err(dev, "Failed to get clock\n");
>  		ret = PTR_ERR(scp->clk);
> @@ -877,6 +877,7 @@ static const struct mtk_scp_of_data mt8192_of_data = {
>  static const struct of_device_id mtk_scp_of_match[] = {
>  	{ .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data },
>  	{ .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data },
> +	{ .compatible = "mediatek,mt8195-scp", .data = &mt8192_of_data },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, mtk_scp_of_match);
> -- 
> 2.18.0
> 

      parent reply	other threads:[~2021-07-30 15:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  3:58 [PATCH v4 0/4] Mediatek MT8195 SCP support Tinghan Shen
2021-07-28  3:58 ` [PATCH v4 1/4] dt-bindings: remoteproc: mediatek: Add binding for mt8195 scp Tinghan Shen
2021-08-02 21:28   ` Rob Herring
2021-07-28  3:58 ` [PATCH v4 2/4] dt-bindings: remoteproc: mediatek: Add binding for mt8192 scp Tinghan Shen
2021-08-02 21:28   ` Rob Herring
2021-07-28  3:58 ` [PATCH v4 3/4] dt-bindings: remoteproc: mediatek: Convert mtk,scp to json-schema Tinghan Shen
2021-07-30 15:56   ` Bjorn Andersson
2021-08-02 21:31   ` Rob Herring
2021-07-28  3:58 ` [PATCH v4 4/4] remoteproc: mediatek: Support mt8195 scp Tinghan Shen
2021-07-29 10:13   ` Tzung-Bi Shih
2021-07-30 15:58   ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQQhjuqAaT1xaIWM@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tinghan.shen@mediatek.com \
    --cc=tzungbi@google.com \
    --subject='Re: [PATCH v4 4/4] remoteproc: mediatek: Support mt8195 scp' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).