LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Chao Yu <chao.yu@linux.dev>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: fix to force keeping write barrier for strict fsync mode
Date: Fri, 30 Jul 2021 15:19:50 -0700	[thread overview]
Message-ID: <YQR7Bi9lI+k2QuYG@google.com> (raw)
In-Reply-To: <bdd499d9-1272-9fe3-8024-f53fbda458bc@kernel.org>

On 07/29, Chao Yu wrote:
> Ping,

Added. Thanks.

> 
> On 2021/7/20 9:19, Chao Yu wrote:
> > On 2021/7/20 9:15, Jaegeuk Kim wrote:
> > > Wasn't it supposed to be v1?
> > 
> > I skip IPU case for v1, and resend it as v3, is it fine to you?
> > 
> > Thanks,
> > 
> > > 
> > > On 07/20, Chao Yu wrote:
> > > > [1] https://www.mail-archive.com/linux-f2fs-devel@lists.sourceforge.net/msg15126.html
> > > > 
> > > > As [1] reported, if lower device doesn't support write barrier, in below
> > > > case:
> > > > 
> > > > - write page #0; persist
> > > > - overwrite page #0
> > > > - fsync
> > > >    - write data page #0 OPU into device's cache
> > > >    - write inode page into device's cache
> > > >    - issue flush
> > > > 
> > > > If SPO is triggered during flush command, inode page can be persisted
> > > > before data page #0, so that after recovery, inode page can be recovered
> > > > with new physical block address of data page #0, however there may
> > > > contains dummy data in new physical block address.
> > > > 
> > > > Then what user will see is: after overwrite & fsync + SPO, old data in
> > > > file was corrupted, if any user do care about such case, we can suggest
> > > > user to use STRICT fsync mode, in this mode, we will force to use atomic
> > > > write sematics to keep write order in between data/node and last node,
> > > > so that it avoids potential data corruption during fsync().
> > > > 
> > > > Signed-off-by: Chao Yu <chao@kernel.org>
> > > > ---
> > > >    fs/f2fs/file.c | 12 ++++++++++++
> > > >    1 file changed, 12 insertions(+)
> > > > 
> > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > > > index 6afd4562335f..00b45876eaa1 100644
> > > > --- a/fs/f2fs/file.c
> > > > +++ b/fs/f2fs/file.c
> > > > @@ -301,6 +301,18 @@ static int f2fs_do_sync_file(struct file *file, loff_t start, loff_t end,
> > > >    				f2fs_exist_written_data(sbi, ino, UPDATE_INO))
> > > >    			goto flush_out;
> > > >    		goto out;
> > > > +	} else {
> > > > +		/*
> > > > +		 * for OPU case, during fsync(), node can be persisted before
> > > > +		 * data when lower device doesn't support write barrier, result
> > > > +		 * in data corruption after SPO.
> > > > +		 * So for strict fsync mode, force to use atomic write sematics
> > > > +		 * to keep write order in between data/node and last node to
> > > > +		 * avoid potential data corruption.
> > > > +		 */
> > > > +		if (F2FS_OPTION(sbi).fsync_mode ==
> > > > +				FSYNC_MODE_STRICT && !atomic)
> > > > +			atomic = true;
> > > >    	}
> > > >    go_write:
> > > >    	/*
> > > > -- 
> > > > 2.22.1
> > 
> > 
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> > 

      reply	other threads:[~2021-07-30 22:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20  1:03 Chao Yu
2021-07-20  1:15 ` Jaegeuk Kim
2021-07-20  1:19   ` Chao Yu
2021-07-29  1:41     ` [f2fs-dev] " Chao Yu
2021-07-30 22:19       ` Jaegeuk Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQR7Bi9lI+k2QuYG@google.com \
    --to=jaegeuk@kernel.org \
    --cc=chao.yu@linux.dev \
    --cc=chao@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [f2fs-dev] [PATCH v3] f2fs: fix to force keeping write barrier for strict fsync mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).