LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jordy Zomer <jordy@pwning.systems>
Cc: dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: usb-dmac: make usb_dmac_get_current_residue unsigned
Date: Sun, 1 Aug 2021 08:27:48 +0200	[thread overview]
Message-ID: <YQY+5OaQKYeWQ+/n@kroah.com> (raw)
In-Reply-To: <20210731091939.510816-1-jordy@pwning.systems>

On Sat, Jul 31, 2021 at 11:19:38AM +0200, Jordy Zomer wrote:
> The usb_dmac_get_current_residue function used to
> take a signed integer as a pos parameter.
> The only callers of this function passes an unsigned integer to it.
> Therefore to make it obviously safe, let's just make this an unsgined
> integer as this is used in pointer arithmetics.
> 
> Signed-off-by: Jordy Zomer <jordy@pwning.systems>
> ---
>  drivers/dma/sh/usb-dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
> index 8f7ceb698226..a5e225c15730 100644
> --- a/drivers/dma/sh/usb-dmac.c
> +++ b/drivers/dma/sh/usb-dmac.c
> @@ -466,7 +466,7 @@ static int usb_dmac_chan_terminate_all(struct dma_chan *chan)
>  
>  static unsigned int usb_dmac_get_current_residue(struct usb_dmac_chan *chan,
>  						 struct usb_dmac_desc *desc,
> -						 int sg_index)
> +						 unsigned int sg_index)
>  {
>  	struct usb_dmac_sg *sg = desc->sg + sg_index;
>  	u32 mem_addr = sg->mem_addr & 0xffffffff;
> -- 
> 2.27.0
> 

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  reply	other threads:[~2021-08-01  6:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31  9:19 Jordy Zomer
2021-08-01  6:27 ` Greg Kroah-Hartman [this message]
2021-08-02  6:46 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQY+5OaQKYeWQ+/n@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=jordy@pwning.systems \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    --subject='Re: [PATCH] dmaengine: usb-dmac: make usb_dmac_get_current_residue unsigned' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).