LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Sandeep Patil <sspatil@android.com>,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.13 001/104] pipe: make pipe writes always wake up readers
Date: Mon, 2 Aug 2021 12:56:36 +0200	[thread overview]
Message-ID: <YQfPZAytBFdFJeH7@kroah.com> (raw)
In-Reply-To: <20210802104831.2095760-1-sashal@kernel.org>

On Mon, Aug 02, 2021 at 06:46:48AM -0400, Sasha Levin wrote:
> From: Linus Torvalds <torvalds@linux-foundation.org>
> 
> commit 3a34b13a88caeb2800ab44a4918f230041b37dd9 upstream.
> 
> Since commit 1b6b26ae7053 ("pipe: fix and clarify pipe write wakeup
> logic") we have sanitized the pipe write logic, and would only try to
> wake up readers if they needed it.
> 
> In particular, if the pipe already had data in it before the write,
> there was no point in trying to wake up a reader, since any existing
> readers must have been aware of the pre-existing data already.  Doing
> extraneous wakeups will only cause potential thundering herd problems.
> 
> However, it turns out that some Android libraries have misused the EPOLL
> interface, and expected "edge triggered" be to "any new write will
> trigger it".  Even if there was no edge in sight.
> 
> Quoting Sandeep Patil:
>  "The commit 1b6b26ae7053 ('pipe: fix and clarify pipe write wakeup
>   logic') changed pipe write logic to wakeup readers only if the pipe
>   was empty at the time of write. However, there are libraries that
>   relied upon the older behavior for notification scheme similar to
>   what's described in [1]
> 
>   One such library 'realm-core'[2] is used by numerous Android
>   applications. The library uses a similar notification mechanism as GNU
>   Make but it never drains the pipe until it is full. When Android moved
>   to v5.10 kernel, all applications using this library stopped working.
> 
>   The library has since been fixed[3] but it will be a while before all
>   applications incorporate the updated library"
> 
> Our regression rule for the kernel is that if applications break from
> new behavior, it's a regression, even if it was because the application
> did something patently wrong.  Also note the original report [4] by
> Michal Kerrisk about a test for this epoll behavior - but at that point
> we didn't know of any actual broken use case.
> 
> So add the extraneous wakeup, to approximate the old behavior.
> 
> [ I say "approximate", because the exact old behavior was to do a wakeup
>   not for each write(), but for each pipe buffer chunk that was filled
>   in. The behavior introduced by this change is not that - this is just
>   "every write will cause a wakeup, whether necessary or not", which
>   seems to be sufficient for the broken library use. ]
> 
> It's worth noting that this adds the extraneous wakeup only for the
> write side, while the read side still considers the "edge" to be purely
> about reading enough from the pipe to allow further writes.
> 
> See commit f467a6a66419 ("pipe: fix and clarify pipe read wakeup logic")
> for the pipe read case, which remains that "only wake up if the pipe was
> full, and we read something from it".
> 
> Link: https://lore.kernel.org/lkml/CAHk-=wjeG0q1vgzu4iJhW5juPkTsjTYmiqiMUYAebWW+0bam6w@mail.gmail.com/ [1]
> Link: https://github.com/realm/realm-core [2]
> Link: https://github.com/realm/realm-core/issues/4666 [3]
> Link: https://lore.kernel.org/lkml/CAKgNAkjMBGeAwF=2MKK758BhxvW58wYTgYKB2V-gY1PwXxrH+Q@mail.gmail.com/ [4]
> Link: https://lore.kernel.org/lkml/20210729222635.2937453-1-sspatil@android.com/
> Reported-by: Sandeep Patil <sspatil@android.com>
> Cc: Michael Kerrisk <mtk.manpages@gmail.com>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  fs/pipe.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

This is already in the 5.13 queue, did you mean to send this again?

thanks,

greg k-h

      reply	other threads:[~2021-08-02 10:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 10:46 Sasha Levin
2021-08-02 10:56 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQfPZAytBFdFJeH7@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=sashal@kernel.org \
    --cc=sspatil@android.com \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH AUTOSEL 5.13 001/104] pipe: make pipe writes always wake up readers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).