LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-staging@lists.linux.dev
Subject: Re: kernel BUG in new r8188eu
Date: Mon, 2 Aug 2021 16:38:53 +0200	[thread overview]
Message-ID: <YQgDfQczxc6LX5yv@kroah.com> (raw)
In-Reply-To: <147993920.vpeT8VCmXh@localhost.localdomain>

On Mon, Aug 02, 2021 at 01:45:06PM +0200, Fabio M. De Francesco wrote:
> Hi Greg,
> 
> On Monday, August 2, 2021 12:36:18 PM CEST Greg Kroah-Hartman wrote:
> > On Sun, Aug 01, 2021 at 03:15:52PM -0500, Larry Finger wrote:
> > > On 8/1/21 1:31 AM, Greg Kroah-Hartman wrote:
> > > > I am worried that my "remove the wrapper" logic got something wrong
> > > > here, so if you could test the revert of that, I would appreciate it.
> > > > 
> > > > I think I need to go buy one of these devices so I can test cleanups
> > > > locally...
> > > 
> > > The bad commit was 9ff1cc4ef80e ("staging: r8188eu: remove rtw_buf_free()
> > > function").
> > > 
> > > Looking at it, the only difference between the original wrapper and the 
> new
> > > code is that the wrapper zeros the len variable before the kfree() call, 
> but
> > > making that change did not help. Reverting that patch restores the old
> > > behavior.
> > 
> > Ah, doh, that was my fault, sorry, that patch was incorrect (odd git id,
> > don't know where that came from, it's a different id in my tree.)  Let
> > me revert this commit and then will redo it correctly.
> 
> The commit to revert should be c7e88ecbe328.

Yes, thanks, now reverted.

> > thanks for finding this.
> > 
> > > There are lots of these on Ebay from $2.47 up with free shipping!
> > 
> > Any hints on the name for how to figure out which devices are supported
> > by this driver?
> 
> The following link points to a device that seems to be supported by this 
> driver. It is just $4.99, but I'm not sure whether or not they ship to Europe 
> (I suppose you're here):
> 
> https://www.amazon.com/gp/product/B00L28AN88/ref=ox_sc_act_title_1

Yeah, I'm in Europe, I'll try to find something within the EU to avoid
the mess with importing electronics and duties.  It's a mess everytime I
do that...

> About this item: 
> * Chipset:RTL8188EU 
> * Standard: IEEE 802.11n,IEEE 802.11g, IEEE 802.11b 
> * Supports 64/128 bit WEP, WPA encryption 
> 
> Otherwise, I think that the following uses the same chip as the above. 
> However, it costs a little more and, above all else, I'm not really sure if it 
> works with r8188eu, since they write that the chip is a Realtek RTL8188EUS 
> (please note that final "EUS"):
> 
> https://www.amazon.it/Asus-USB-N10-NANO-N150-compatibile/dp/B081758CWC/
> ref=sr_1_1

Yeah, I found a bunch of "EUS" devices here, will keep digging.

thanks,

greg k-h

  reply	other threads:[~2021-08-02 18:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 19:59 Larry Finger
2021-07-31  5:37 ` Greg Kroah-Hartman
2021-07-31 16:18   ` Larry Finger
2021-07-31 18:53     ` Fabio Aiuto
2021-07-31 21:54       ` Larry Finger
2021-08-01  6:31     ` Greg Kroah-Hartman
2021-08-01 20:15       ` Larry Finger
2021-08-02 10:36         ` Greg Kroah-Hartman
2021-08-02 11:45           ` Fabio M. De Francesco
2021-08-02 14:38             ` Greg Kroah-Hartman [this message]
2021-08-02 14:40             ` Larry Finger
2021-08-02 15:46               ` Greg Kroah-Hartman
2021-08-02 14:49           ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQgDfQczxc6LX5yv@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --subject='Re: kernel BUG in new r8188eu' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).