LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alistair23@gmail.com
Subject: Re: [PATCH v8 02/11] mfd: sy7636a: Initial commit
Date: Tue, 3 Aug 2021 14:16:37 +0100	[thread overview]
Message-ID: <YQlBtQDrVHqh3N5D@google.com> (raw)
In-Reply-To: <20210803084456.198-2-alistair@alistair23.me>

On Tue, 03 Aug 2021, Alistair Francis wrote:

> Initial support for the Silergy SY7636A Power Management chip.
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
>  drivers/mfd/Kconfig         |  9 +++++
>  drivers/mfd/Makefile        |  1 +
>  drivers/mfd/sy7636a.c       | 72 +++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/sy7636a.h | 45 +++++++++++++++++++++++
>  4 files changed, 127 insertions(+)
>  create mode 100644 drivers/mfd/sy7636a.c
>  create mode 100644 include/linux/mfd/sy7636a.h
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6a3fd2d75f96..b82208f0c79c 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1352,6 +1352,15 @@ config MFD_SYSCON
>  	  Select this option to enable accessing system control registers
>  	  via regmap.
>  
> +config MFD_SY7636A
> +	tristate "Silergy SY7636A Power Management IC"
> +	select MFD_CORE
> +	select REGMAP_I2C
> +	depends on I2C
> +	help
> +	  Select this option to enable support for the Silergy SY7636A
> +	  Power Management IC.
> +
>  config MFD_DAVINCI_VOICECODEC
>  	tristate
>  	select MFD_CORE
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 8116c19d5fd4..cbe581e87fa9 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -266,6 +266,7 @@ obj-$(CONFIG_MFD_KHADAS_MCU) 	+= khadas-mcu.o
>  obj-$(CONFIG_MFD_ACER_A500_EC)	+= acer-ec-a500.o
>  obj-$(CONFIG_MFD_QCOM_PM8008)	+= qcom-pm8008.o
>  
> +obj-$(CONFIG_MFD_SY7636A)	+= sy7636a.o
>  obj-$(CONFIG_SGI_MFD_IOC3)	+= ioc3.o
>  obj-$(CONFIG_MFD_SIMPLE_MFD_I2C)	+= simple-mfd-i2c.o
>  obj-$(CONFIG_MFD_INTEL_M10_BMC)   += intel-m10-bmc.o
> diff --git a/drivers/mfd/sy7636a.c b/drivers/mfd/sy7636a.c
> new file mode 100644
> index 000000000000..f3ff93c7395d
> --- /dev/null
> +++ b/drivers/mfd/sy7636a.c
> @@ -0,0 +1,72 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * MFD parent driver for SY7636A chip
> + *
> + * Copyright (C) 2021 reMarkable AS - http://www.remarkable.com/
> + *
> + * Authors: Lars Ivar Miljeteig <lars.ivar.miljeteig@remarkable.com>
> + *          Alistair Francis <alistair@alistair23.me>
> + *
> + * Based on the lp87565 driver by Keerthy <j-keerthy@ti.com>
> + */
> +
> +#include <linux/interrupt.h>
> +#include <linux/mfd/core.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +
> +#include <linux/mfd/sy7636a.h>
> +
> +static const struct regmap_config sy7636a_regmap_config = {
> +	.reg_bits = 8,
> +	.val_bits = 8,
> +};
> +
> +static const struct mfd_cell sy7636a_cells[] = {
> +	{ .name = "sy7636a-regulator", },

What kind of regulator is 'vcom'? LDO? DCDC?

> +	{ .name = "sy7636a-temperature", },
> +	{ .name = "sy7636a-thermal", },
> +};

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2021-08-03 13:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  8:44 [PATCH v8 01/11] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Alistair Francis
2021-08-03  8:44 ` [PATCH v8 02/11] mfd: sy7636a: Initial commit Alistair Francis
2021-08-03 13:16   ` Lee Jones [this message]
2021-08-04  8:22     ` Alistair Francis
2021-08-04  9:06       ` Lee Jones
2021-08-04  9:37         ` Alistair Francis
2021-08-04 10:28           ` Lee Jones
2021-08-04 10:35             ` Alistair Francis
2021-08-03  8:44 ` [PATCH v8 03/11] thermal: sy7636a: Add thermal driver for sy7636a Alistair Francis
2021-08-03  8:44 ` [PATCH v8 04/11] hwmon: sy7636a: Add temperature " Alistair Francis
2021-08-03  8:44 ` [PATCH v8 05/11] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
2021-08-03  8:44 ` [PATCH v8 06/11] regulator: sy7636a: Use the parent driver data Alistair Francis
2021-08-03  8:44 ` [PATCH v8 07/11] regulator: sy7636a: Store the epd-pwr-good GPIO locally Alistair Francis
2021-08-03  8:44 ` [PATCH v8 08/11] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis
2021-08-03  8:44 ` [PATCH v8 09/11] ARM: dts: imx7d: remarkable2: " Alistair Francis
2021-08-04 12:43   ` Lee Jones
2021-08-05  8:05     ` Alistair Francis
2021-08-05  8:26       ` Lee Jones
2021-08-05  8:37         ` Alistair Francis
2021-08-03 22:35 ` (subset) [PATCH v8 01/11] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQlBtQDrVHqh3N5D@google.com \
    --to=lee.jones@linaro.org \
    --cc=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v8 02/11] mfd: sy7636a: Initial commit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).