LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] of: fdt: do not update local variable after use
       [not found] <CGME20210803101726epcas1p257df1a6ab948c39304f4246a95d039c3@epcas1p2.samsung.com>
@ 2021-08-03 10:13 ` Ohhoon Kwon
  2021-08-03 20:20   ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Ohhoon Kwon @ 2021-08-03 10:13 UTC (permalink / raw)
  To: robh+dt, frowand.list
  Cc: ohoono.kwon, ohkwon1043, nathan, devicetree, linux-kernel

Fix the below warning:
drivers/of/fdt.c:196:4: warning: Value stored to 'pprev' is never read
[clang-analyzer-deadcode.DeadStores]
             pprev      = &pp->next;
             ^            ~~~~~~~~~

Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com>
---
 drivers/of/fdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index bd35ba56aa96..5dc0b0310d7c 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -193,7 +193,6 @@ static void populate_properties(const void *blob,
 			pp->length = len;
 			pp->value  = pp + 1;
 			*pprev     = pp;
-			pprev      = &pp->next;
 			memcpy(pp->value, ps, len - 1);
 			((char *)pp->value)[len - 1] = 0;
 			pr_debug("fixed up name for %s -> %s\n",
-- 
2.32.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] of: fdt: do not update local variable after use
  2021-08-03 10:13 ` [PATCH] of: fdt: do not update local variable after use Ohhoon Kwon
@ 2021-08-03 20:20   ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-08-03 20:20 UTC (permalink / raw)
  To: Ohhoon Kwon
  Cc: linux-kernel, frowand.list, devicetree, robh+dt, ohkwon1043, nathan

On Tue, 03 Aug 2021 19:13:09 +0900, Ohhoon Kwon wrote:
> Fix the below warning:
> drivers/of/fdt.c:196:4: warning: Value stored to 'pprev' is never read
> [clang-analyzer-deadcode.DeadStores]
>              pprev      = &pp->next;
>              ^            ~~~~~~~~~
> 
> Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com>
> ---
>  drivers/of/fdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-03 20:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210803101726epcas1p257df1a6ab948c39304f4246a95d039c3@epcas1p2.samsung.com>
2021-08-03 10:13 ` [PATCH] of: fdt: do not update local variable after use Ohhoon Kwon
2021-08-03 20:20   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).