LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Salah Triki <salah.triki@gmail.com>,
	Fabio Aiuto <fabioaiuto83@gmail.com>,
	Ross Schmidt <ross.schm.dev@gmail.com>,
	Marco Cesati <marcocesati@gmail.com>,
	Brother Matthew De Angelis <matthew.v.deangelis@gmail.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Ivan Safonov <insafonov@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tablet: acecad: update the reference count of the usb interface structure
Date: Wed, 4 Aug 2021 14:03:00 +0200	[thread overview]
Message-ID: <YQqB9Pl1tvloKHWZ@kroah.com> (raw)
In-Reply-To: <20210804105838.GE1931@kadam>

On Wed, Aug 04, 2021 at 01:58:38PM +0300, Dan Carpenter wrote:
> On Sat, Jul 31, 2021 at 05:09:38PM +0100, Salah Triki wrote:
> >  drivers/input/tablet/acecad.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/tablet/acecad.c b/drivers/input/tablet/acecad.c
> > index a38d1fe97334..85fe134a30ee 100644
> > --- a/drivers/input/tablet/acecad.c
> > +++ b/drivers/input/tablet/acecad.c
> > @@ -151,7 +151,7 @@ static int usb_acecad_probe(struct usb_interface *intf, const struct usb_device_
> >  		goto fail2;
> >  	}
> >  
> > -	acecad->intf = intf;
> > +	acecad->intf = usb_get_intf(intf);
> >  	acecad->input = input_dev;
> >  
> >  	if (dev->manufacturer)
> 
> As I mentioned earlier, you need to drop the reference if
> input_register_device() fails.

Also as mentioned in other threads, this is not needed at all.

  reply	other threads:[~2021-08-04 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 16:09 Salah Triki
2021-08-04 10:58 ` Dan Carpenter
2021-08-04 12:03   ` Greg Kroah-Hartman [this message]
2021-08-04 11:03 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQqB9Pl1tvloKHWZ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=gustavoars@kernel.org \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=marcocesati@gmail.com \
    --cc=matthew.v.deangelis@gmail.com \
    --cc=ross.schm.dev@gmail.com \
    --cc=salah.triki@gmail.com \
    --subject='Re: [PATCH v2] tablet: acecad: update the reference count of the usb interface structure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).