LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dt-bindings: hisilicon,hi6421-spmi-pmic.yaml: make some rules stricter
@ 2021-07-24  8:41 Mauro Carvalho Chehab
  2021-08-05 13:09 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2021-07-24  8:41 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linuxarm, mauro.chehab, Mauro Carvalho Chehab, Rob Herring,
	Lee Jones, Rob Herring, devicetree, linux-kernel

Define maxItems for interrupts and accept only "ldo" in lower case.

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
Greg,

Please apply this patch on your staging tree. It addresses the remaining
bits from Rob's review.

I'll submit the DTS patches via HiSilicon tree, c/c you and Rob.

 .../mfd/hisilicon,hi6421-spmi-pmic.yaml       | 21 ++++++++++---------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
index cedf9d99a34b..22edcb4b212f 100644
--- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
@@ -34,7 +34,8 @@ properties:
 
   interrupt-controller: true
 
-  interrupts: true
+  interrupts:
+    maxItems: 1
 
   regulators:
     type: object
@@ -49,7 +50,7 @@ properties:
         const: 0
 
     patternProperties:
-      '^(ldo|LDO)[0-9]+$':
+      '^ldo[0-9]+$':
         type: object
 
         $ref: "/schemas/regulator/regulator.yaml#"
@@ -79,55 +80,55 @@ examples:
         #address-cells = <1>;
         #size-cells = <0>;
 
-        ldo3: LDO3 {
+        ldo3: ldo3 {
           regulator-name = "ldo3";
           regulator-min-microvolt = <1500000>;
           regulator-max-microvolt = <2000000>;
           regulator-boot-on;
         };
 
-        ldo4: LDO4 {
+        ldo4: ldo4 {
           regulator-name = "ldo4";
           regulator-min-microvolt = <1725000>;
           regulator-max-microvolt = <1900000>;
           regulator-boot-on;
         };
 
-        ldo9: LDO9 {
+        ldo9: ldo9 {
           regulator-name = "ldo9";
           regulator-min-microvolt = <1750000>;
           regulator-max-microvolt = <3300000>;
           regulator-boot-on;
         };
 
-        ldo15: LDO15 {
+        ldo15: ldo15 {
           regulator-name = "ldo15";
           regulator-min-microvolt = <1800000>;
           regulator-max-microvolt = <3000000>;
           regulator-always-on;
         };
 
-        ldo16: LDO16 {
+        ldo16: ldo16 {
           regulator-name = "ldo16";
           regulator-min-microvolt = <1800000>;
           regulator-max-microvolt = <3000000>;
           regulator-boot-on;
         };
 
-        ldo17: LDO17 {
+        ldo17: ldo17 {
           regulator-name = "ldo17";
           regulator-min-microvolt = <2500000>;
           regulator-max-microvolt = <3300000>;
         };
 
-        ldo33: LDO33 {
+        ldo33: ldo33 {
           regulator-name = "ldo33";
           regulator-min-microvolt = <2500000>;
           regulator-max-microvolt = <3300000>;
           regulator-boot-on;
         };
 
-        ldo34: LDO34 {
+        ldo34: ldo34 {
           regulator-name = "ldo34";
           regulator-min-microvolt = <2600000>;
           regulator-max-microvolt = <3300000>;
-- 
2.31.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: hisilicon,hi6421-spmi-pmic.yaml: make some rules stricter
  2021-07-24  8:41 [PATCH] dt-bindings: hisilicon,hi6421-spmi-pmic.yaml: make some rules stricter Mauro Carvalho Chehab
@ 2021-08-05 13:09 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2021-08-05 13:09 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Greg Kroah-Hartman, linuxarm, mauro.chehab, Rob Herring,
	Rob Herring, devicetree, linux-kernel

On Sat, 24 Jul 2021, Mauro Carvalho Chehab wrote:

> Define maxItems for interrupts and accept only "ldo" in lower case.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> Greg,
> 
> Please apply this patch on your staging tree. It addresses the remaining
> bits from Rob's review.
> 
> I'll submit the DTS patches via HiSilicon tree, c/c you and Rob.
> 
>  .../mfd/hisilicon,hi6421-spmi-pmic.yaml       | 21 ++++++++++---------
>  1 file changed, 11 insertions(+), 10 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-05 13:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-24  8:41 [PATCH] dt-bindings: hisilicon,hi6421-spmi-pmic.yaml: make some rules stricter Mauro Carvalho Chehab
2021-08-05 13:09 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).