From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A1EAC4320A for ; Thu, 5 Aug 2021 23:51:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15DBB61108 for ; Thu, 5 Aug 2021 23:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242568AbhHEXvq (ORCPT ); Thu, 5 Aug 2021 19:51:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242554AbhHEXvo (ORCPT ); Thu, 5 Aug 2021 19:51:44 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A1DEC0613D5 for ; Thu, 5 Aug 2021 16:51:29 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id cl16-20020a17090af690b02901782c35c4ccso9816610pjb.5 for ; Thu, 05 Aug 2021 16:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LvXvxc4FpfdQsNTQ2uP7M38rxQUNtPKsYk8dUCbk8vw=; b=RFz/Y/FntKBu086yBh8DOvEcoTbXW+UBSqeBcOSLniuR8fpBhTS4XE4KGiQqVWqTlT IByvUcFYRGdsnr80Wh7XaXMnHzQ/L0RXnuUg/7TP6zKxhc5pojD8RsY3/yOiXPcoPY7I Pk327FGZesE/IJlh1S2JpNE024prgZBIy+WLM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LvXvxc4FpfdQsNTQ2uP7M38rxQUNtPKsYk8dUCbk8vw=; b=lHdm8NnWMvKR9wJTbttBGsErCuNNiRW5QqGaZ0hl7ouYFlMcLhCKWyLtPrs/zkqFlY XfqhfMnhvCE7idbZONxkKdHKcGotdaL2QeGUDcf1gJEABbbrkiXJcMCNL5onVpku0Y0a hHf48Rvjnqn5VW/XMwEYYfZDEvzkSFMVvXG/tRFzbOwhsvbkVrju3DUeznqDD5vhDTJm TSsbkivNmD3Whe4BQ8qmSCh+nFVUnHUo0EJJNetHksc7LiEWf39Ul9rCHJA4cLgUiWf2 nDMKGencCl28pAo8WCTpzViQsWhbap37saMPDb6N5LgmEjA0qRZXdjLB4s8rpBXBUq37 nc2Q== X-Gm-Message-State: AOAM530EEub7wluK++nhhZgFRNyu+jlOCMk8Xk4tslCZLgFsrwnEYD/K ggpNOeXudqqaTs+bvkwi/HdFZA== X-Google-Smtp-Source: ABdhPJx7XizOixq0HL7mC9NkNAJ0u2Ph2L3oW2+f1ilfNne9wrBdgsgcQQu8QVqLF9KyU4Zt1X8+1g== X-Received: by 2002:a17:90a:9511:: with SMTP id t17mr17926916pjo.194.1628207488974; Thu, 05 Aug 2021 16:51:28 -0700 (PDT) Received: from localhost ([2620:15c:202:201:8944:bd:9484:29e]) by smtp.gmail.com with UTF8SMTPSA id t22sm9144685pgv.35.2021.08.05.16.51.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 16:51:28 -0700 (PDT) Date: Thu, 5 Aug 2021 16:51:27 -0700 From: Matthias Kaehlcke To: Alex Elder Cc: bjorn.andersson@linaro.org, agross@kernel.org, robh+dt@kernel.org, elder@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc7280: add IPA information Message-ID: References: <20210804210214.1891755-1-elder@linaro.org> <20210804210214.1891755-2-elder@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210804210214.1891755-2-elder@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 04:02:11PM -0500, Alex Elder wrote: > Add IPA-related nodes and definitions to "sc7280.dtsi", including > the reserved memory area used for AP-based IPA firmware loading. > > Signed-off-by: Alex Elder > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 42 ++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 029723a75edef..5764c5b5cae17 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -69,6 +69,11 @@ cpucp_mem: memory@80b00000 { > no-map; > reg = <0x0 0x80b00000 0x0 0x100000>; > }; > + > + ipa_fw_mem: memory@8b700000 { > + reg = <0 0x8b700000 0 0x10000>; > + no-map; > + }; > }; > > cpus { > @@ -568,6 +573,43 @@ mmss_noc: interconnect@1740000 { > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > + ipa: ipa@1e40000 { > + compatible = "qcom,sc7280-ipa"; > + > + iommus = <&apps_smmu 0x480 0x0>, > + <&apps_smmu 0x482 0x0>; > + reg = <0 0x1e40000 0 0x8000>, > + <0 0x1e50000 0 0x4ad0>, > + <0 0x1e04000 0 0x23000>; > + reg-names = "ipa-reg", > + "ipa-shared", > + "gsi"; > + > + interrupts-extended = <&intc 0 654 IRQ_TYPE_EDGE_RISING>, > + <&intc 0 432 IRQ_TYPE_LEVEL_HIGH>, nit: use GIC_SPI for the interrupt type > + <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "ipa", > + "gsi", > + "ipa-clock-query", > + "ipa-setup-ready"; > + > + clocks = <&rpmhcc RPMH_IPA_CLK>; > + clock-names = "core"; > + > + interconnects = <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>, > + <&gem_noc MASTER_APPSS_PROC 0 &cnoc2 SLAVE_IPA_CFG 0>; > + interconnect-names = "memory", > + "config"; > + > + qcom,smem-states = <&ipa_smp2p_out 0>, > + <&ipa_smp2p_out 1>; > + qcom,smem-state-names = "ipa-clock-enabled-valid", > + "ipa-clock-enabled"; > + > + status = "disabled"; > + }; > + I know little about IPA, but besides the nit this looks sane to me. Reviewed-by: Matthias Kaehlcke