LKML Archive on
help / color / mirror / Atom feed
From: Matthew Wilcox <>
To: Hugh Dickins <>
Cc: Andrew Morton <>,,,
Subject: Re: [PATCH] mm: Remove bogus VM_BUG_ON
Date: Wed, 18 Aug 2021 17:45:25 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Aug 18, 2021 at 09:34:51AM -0700, Hugh Dickins wrote:
> On Wed, 18 Aug 2021, Matthew Wilcox (Oracle) wrote:
> > It is not safe to check page->index without holding the page lock.
> > It can be changed if the page is moved between the swap cache and the
> > page cache for a shmem file, for example.  There is a VM_BUG_ON below
> > which checks page->index is correct after taking the page lock.
> > 
> > Cc:
> > Fixes: 5c211ba29deb ("mm: add and use find_lock_entries")
> I don't mind that VM_BUG_ON_PAGE() being removed, but question whether
> this Fixes anything, and needs to go to stable. Or maybe it's just that
> the shmem example is wrong - moving shmem from page to swap cache does
> not change page->index. Or maybe you have later changes in your tree
> which change that and do require this. Otherwise, I'll have to worry
> why my testing has missed it for six months.

I'm sorry, I think you're going to have to worry :-(  Syzbot found
it initially:

and then I hit it today during my testing (which is definitely due to
further changes in my tree).

I should have added:


  reply	other threads:[~2021-08-18 16:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 14:49 Matthew Wilcox (Oracle)
2021-08-18 16:34 ` Hugh Dickins
2021-08-18 16:45   ` Matthew Wilcox [this message]
2021-08-19 20:42     ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] mm: Remove bogus VM_BUG_ON' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).