LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com
Subject: Re: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value
Date: Wed, 18 Aug 2021 16:05:12 +0200	[thread overview]
Message-ID: <YR0TmJJ/WkfE2zkR@kroah.com> (raw)
In-Reply-To: <20210817063058.4718-1-sherry.sun@nxp.com>

On Tue, Aug 17, 2021 at 02:30:58PM +0800, Sherry Sun wrote:
> From: Andy Duan <fugang.duan@nxp.com>
> 
> Register offset needs to be applied on mapbase also.
> dma_tx/rx_request use the physical address of UARTDATA.
> Register offset is currently only applied to membase (the
> corresponding virtual addr) but not on mapbase.
> 
> Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> Acked-by: Fugang Duan <fugang.duan@nxp.com>
> Signed-off-by: Adriana Reus <adriana.reus@nxp.com>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---

Why is there no signed-off-by from the author?

Please fix up.

thanks,

greg k-h

  reply	other threads:[~2021-08-18 14:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  6:30 Sherry Sun
2021-08-18 14:05 ` Greg KH [this message]
2021-08-19  1:27   ` Sherry Sun
2021-08-19  1:54 ` Fabio Estevam
2021-08-19  2:03   ` Sherry Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YR0TmJJ/WkfE2zkR@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sherry.sun@nxp.com \
    --subject='Re: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).