From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69701C4320A for ; Wed, 18 Aug 2021 18:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BF4D610FA for ; Wed, 18 Aug 2021 18:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232879AbhHRSrT (ORCPT ); Wed, 18 Aug 2021 14:47:19 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57042 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbhHRSrS (ORCPT ); Wed, 18 Aug 2021 14:47:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=LslqnICK2K9Z5nZFOWZxRkc5IKeWWca/EEMOYqP7v/I=; b=lyinVlL4NDDv+cfNkZorZRKcat fQQkhAVP6rk6yRdCOEfirqNfGepBukIALi3lSeJdBL3J2Wx/8N/daZS1kiTuvSXOYUQHNQffzFUmb LpSdtDYm6pv4+zceGWbbFGAlu+ZvIP4GPJVN9ZxW18mGWz0ya0cD1waKifXcIAHq2N80=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mGQa6-000pTB-53; Wed, 18 Aug 2021 20:46:30 +0200 Date: Wed, 18 Aug 2021 20:46:30 +0200 From: Andrew Lunn To: Saravana Kannan Cc: Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Marc Zyngier , Neil Armstrong , Kevin Hilman , kernel-team@android.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2 1/3] net: mdio-mux: Delete unnecessary devm_kfree Message-ID: References: <20210817180841.3210484-1-saravanak@google.com> <20210817180841.3210484-2-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 07:56:42PM -0700, Saravana Kannan wrote: > On Tue, Aug 17, 2021 at 2:10 PM Andrew Lunn wrote: > > > > On Tue, Aug 17, 2021 at 11:08:39AM -0700, Saravana Kannan wrote: > > > The whole point of devm_* APIs is that you don't have to undo them if you > > > are returning an error that's going to get propagated out of a probe() > > > function. So delete unnecessary devm_kfree() call in the error return path. > > > > > > Signed-off-by: Saravana Kannan > > > Reviewed-by: Andrew Lunn > > > Acked-by: Marc Zyngier > > > Tested-by: Marc Zyngier > > > Acked-by: Kevin Hilman > > > Tested-by: Kevin Hilman > > > > Please add a Fixes: tag, since you want this in stable. > > > > All three patches need fixes tags, possibly different for each patch? > > I generally ask for patches to be picked up by stable only if it fixes > a bug that puts the kernel in a bad state Actually, you asked for stable. You set the subject to [PATCH net v3 0/3] Clean up and fix error where [PATCH net ] means stable. If you think this is just ongoing development work, use [PATCH net-next ]. Then the Fixes tags are optional. Andrew