From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6792AC4320A for ; Thu, 19 Aug 2021 03:03:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C631610FE for ; Thu, 19 Aug 2021 03:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235914AbhHSDDn (ORCPT ); Wed, 18 Aug 2021 23:03:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235792AbhHSDDl (ORCPT ); Wed, 18 Aug 2021 23:03:41 -0400 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BDCDC0613D9 for ; Wed, 18 Aug 2021 20:03:05 -0700 (PDT) Received: by mail-oi1-x235.google.com with SMTP id n27so6631810oij.0 for ; Wed, 18 Aug 2021 20:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oLtmGWWWFpy0RrcCLUcbKoN2iq+DyMnqMq+mMo4DPc4=; b=eangeZEGbtS69BS4hN/L+x7MnIZ8dMi46+6iuZFfHLBX2wwl5y6oWH6Vf6wOLJayeu OPfonrfs7f+MMVUmvYb2sEH+dC2baGKAn1mqncorX+ueqV2rLSfdAs/U5xZSC50XLC/w N7YXYEIrK2+JqGNPOPEeByI756min3FkQJ9UgtutLBuNYOwQ4rCUcXyJAvFPrgw7RIrY H7Zpp8R5MJZz21lamrc8IJCO8BAGVEY7xd5FrcVrOqkNLIPTvS5esUDmP8UBqO1yJ8i5 EX31ASk7UEpM1JNc41WXtS6UyDJQtT7Qb1Y5zrbiuUH6cbE7vSZIKiQ/JeKLfOenHeuP eL1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oLtmGWWWFpy0RrcCLUcbKoN2iq+DyMnqMq+mMo4DPc4=; b=d9hxwPQSD8/hwvIC9ct1g+u1vSs0znYKEevnzyh88jNz6CYmHZf+hPRSP+7lPSShUt BY4mx80X3DWUFCF4tqYGRWM9fB5HAxseykzN0fynt7pWLbkDpZAK4qWFHP6QrBCIaqJ8 VckjMIiigMFqJubKYtvFoiblAFVDL+td0kX6tglJUKUMsaGqIknuIBXnDs060mbWeglX 2r3VfFS82cBaLmvkg3ZB7svWwhXbnbPAHnyPkbpCzX3G/BkwPBNkJSHEj5+0g8H/efvx Jtz6nfExXaIiZvaBvpj5vNBY0UlJFOQcBzS7/ge/ajMLr1j1dS+jgy8TkoJKwQM4+/A+ 5pJA== X-Gm-Message-State: AOAM530993WKZSXjBRfN7Hz7TFbAUzJucKfjY/4dtnEXGUGMOqDhSS/2 c45JB1Ek0lODhtOYQbkx072agw== X-Google-Smtp-Source: ABdhPJzCCQcupwH4mOOFBHjl11BaWd+S5X0W91b9Y+9RFM8yUV8G/G+t8Ov9Nw/Bu8UbM4AsfBGugw== X-Received: by 2002:aca:1a0f:: with SMTP id a15mr991874oia.42.1629342184854; Wed, 18 Aug 2021 20:03:04 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id w14sm436276otl.58.2021.08.18.20.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 20:03:04 -0700 (PDT) Date: Wed, 18 Aug 2021 22:03:02 -0500 From: Bjorn Andersson To: quic_vamslank@quicinc.com Cc: agross@kernel.org, linus.walleij@linaro.org, manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SDX65 pinctrl bindings Message-ID: References: <341f8af967fb0c699996a8f73d34c2b8bd0789cc.1626987605.git.quic_vamslank@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <341f8af967fb0c699996a8f73d34c2b8bd0789cc.1626987605.git.quic_vamslank@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 22 Jul 16:18 CDT 2021, quic_vamslank@quicinc.com wrote: > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml [..] > +'$defs': > + qcom-sdx65-tlmm-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > + > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this subnode. > + items: > + oneOf: > + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-1][0-6])$" The last part doesn't seem right and this gives us the following possible values gpio0-9, gpio10-99, gpio100-106 and gpio110-116. I think the correct pattern would be: "^gpio([0-9]|[1-9][0-9]|10[0-9])$" [..] > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-controller > + - '#interrupt-cells' > + - gpio-controller > + - '#gpio-cells' > + - gpio-ranges > + > +additionalProperties: false > + > +examples: > + - | > + #include > + tlmm: pinctrl@f100000{ Please include a space between the unit address and '{'. > + compatible = "qcom,sdx65-tlmm"; > + reg = <0x03000000 0xdc2000>; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&tlmm 0 0 109>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = ; > + > + serial-pins { > + pins = "gpio8", "gpio9"; > + function = "blsp_uart3"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + uart-w-subnodes-state { This line is indented with tabs, the rest with spaces. With those changes this looks really good. Thanks, Bjorn