LKML Archive on
help / color / mirror / Atom feed
From: Bjorn Andersson <>
Subject: Re: [PATCH v2 2/2] pinctrl: qcom: Add SDX65 pincontrol driver
Date: Wed, 18 Aug 2021 22:09:30 -0500	[thread overview]
Message-ID: <YR3Lah3xSMnrfXSd@builder.lan> (raw)
In-Reply-To: <>

On Thu 22 Jul 16:18 CDT 2021, wrote:
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdx65.c b/drivers/pinctrl/qcom/pinctrl-sdx65.c
> +enum sdx65_functions {
> +	msm_mux_QLINK0_WMSS,

I think this would be more aesthetically pleasing if it was lower case,
like all the other entries. Can you please fix that?

With that:

Reviewed-by: Bjorn Andersson <>


  reply	other threads:[~2021-08-19  3:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 21:18 [PATCH v2 0/2] Add pinctrl support for SDX65 quic_vamslank
2021-07-22 21:18 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SDX65 pinctrl bindings quic_vamslank
2021-08-19  3:03   ` Bjorn Andersson
2021-07-22 21:18 ` [PATCH v2 2/2] pinctrl: qcom: Add SDX65 pincontrol driver quic_vamslank
2021-08-19  3:09   ` Bjorn Andersson [this message]
2021-07-30 10:02 ` [PATCH v2 0/2] Add pinctrl support for SDX65 Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YR3Lah3xSMnrfXSd@builder.lan \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 2/2] pinctrl: qcom: Add SDX65 pincontrol driver' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).