LKML Archive on
help / color / mirror / Atom feed
From: Andy Shevchenko <>
To: Mihai Carabas <>
Subject: Re: [PATCH] misc/pvpanic: fix set driver data
Date: Thu, 19 Aug 2021 15:30:08 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Aug 18, 2021 at 06:38:30PM +0300, Mihai Carabas wrote:

Thank you for the report and fix! My comments below.

> Add again dev_set_drvdata in order for dev_get_drvdata to not return NULL.


> Fixes: 394febc9d0a6 ("misc/pvpanic: Make 'pvpanic_probe()' resource managed")


Shouldn't be blank line(s) in the tag block.

> Signed-off-by: Mihai Carabas <>


> +	dev_set_drvdata(dev, pi);
> +
>  	return devm_pvpanic_probe(dev, pi);

I think it makes sense to have the above line as a part of pvpanic_probe().

With Best Regards,
Andy Shevchenko

      parent reply	other threads:[~2021-08-19 12:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 15:38 [PATCH] misc/pvpanic: fix panic on accessing sysfs entries Mihai Carabas
2021-08-18 15:38 ` [PATCH] misc/pvpanic: fix set driver data Mihai Carabas
2021-08-18 21:59   ` kernel test robot
2021-08-19 12:30   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] misc/pvpanic: fix set driver data' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).