LKML Archive on
help / color / mirror / Atom feed
From: Ming Lei <>
To: Christoph Hellwig <>
Cc: Jens Axboe <>,,,
	Dan Schatzberg <>
Subject: Re: [PATCH V4 0/7] loop: cleanup charging io to mem/blkcg
Date: Tue, 10 Aug 2021 11:26:54 +0800	[thread overview]
Message-ID: <YRHx/qaKgEqWdXOP@T590> (raw)
In-Reply-To: <>

Hi Chritoph,

On Mon, Aug 09, 2021 at 08:41:59AM +0200, Christoph Hellwig wrote:
> FYI, I am still of the firm opinion that the current cgroup support in
> the loop driver needs to be reverted and be redone cleanly from scratch
> without impacting the normal non-cgroup path at all.

This patchset basically re-writes the original patches much or less, and the
normal non-cgroup path is basically not changed compared with before
87579e9b7d8d ("loop: use worker per cgroup instead of kworker").
Original way is to use kthread_work, now it is switched to queue_work()
for unifying the code, but all commands are just added to one list and run
batching in the single worker context, which is very similar with kthread_worker.

Can you share us what your expectations are in the re-write? Such as:

1) no impact on normal non-cgroup path
2) ...
3) ...


  reply	other threads:[~2021-08-10  3:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06  8:02 Ming Lei
2021-08-06  8:02 ` [PATCH V4 1/7] mm: memcontrol: add helper of memcg_get_e_css Ming Lei
2021-08-12  8:58   ` Christoph Hellwig
2021-08-06  8:02 ` [PATCH V4 2/7] loop: clean up blkcg association Ming Lei
2021-08-12  8:59   ` Christoph Hellwig
2021-08-06  8:02 ` [PATCH V4 3/7] loop: conver timer for monitoring idle worker into dwork Ming Lei
2021-08-06  8:02 ` [PATCH V4 4/7] loop: add __loop_free_idle_workers() for covering freeing workers in clearing FD Ming Lei
2021-08-06  8:03 ` [PATCH V4 5/7] loop: improve loop_process_work Ming Lei
2021-08-06  8:03 ` [PATCH V4 6/7] loop: use xarray to store workers Ming Lei
2021-08-06  8:03 ` [PATCH V4 7/7] loop: don't add worker into idle list Ming Lei
2021-08-09  6:41 ` [PATCH V4 0/7] loop: cleanup charging io to mem/blkcg Christoph Hellwig
2021-08-10  3:26   ` Ming Lei [this message]
2021-08-12  9:00     ` Christoph Hellwig
2021-08-14  9:12       ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRHx/qaKgEqWdXOP@T590 \ \ \ \ \ \ \
    --subject='Re: [PATCH V4 0/7] loop: cleanup charging io to mem/blkcg' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).