LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules
Date: Tue, 10 Aug 2021 08:58:14 +0100	[thread overview]
Message-ID: <YRIxluiYdZo9OOAn@google.com> (raw)
In-Reply-To: <CAMuHMdXpYV+pbiOwiCjZ+aZYR-xPDGkeANfLt0fwhg4zevAKgg@mail.gmail.com>

On Mon, 09 Aug 2021, Geert Uytterhoeven wrote:

> On Tue, Aug 3, 2021 at 5:56 PM Lee Jones <lee.jones@linaro.org> wrote:
> > A recent attempt to convert the Power Reset Restart driver to tristate
> > failed because of the following compile error (reported once merged by
> > Stephen Rothwell via Linux Next):
> >
> >   ERROR: "machine_restart" [drivers/power/reset/restart-poweroff.ko] undefined!
> >
> > This error occurs since some of the machine_restart() instances are
> > not currently exported for use in modules.  This patch aims to rectify
> > that.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> 
> > NB: If it's safe to omit some of these, let me know and I'll revise the patch.
> 
> How do you plan to handle that? Isn't this an all-or-nothing export?

That's the way I see it, but I don't have an in-depth knowledge of all
of the architectures.  There may be a method there that isn't part of
the core API.  If that's the case, I can drop the export.

> >  arch/m68k/kernel/process.c         | 1 +
> 
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks Geert.

I'll pick this up when I do the re-spin shortly.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2021-08-10  7:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03 15:54 [PATCH 0/3] power: reset: Convert Power-Off driver to tristate Lee Jones
2021-08-03 15:54 ` [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Lee Jones
2021-08-09 15:15   ` Geert Uytterhoeven
2021-08-10  7:58     ` Lee Jones [this message]
2021-08-03 15:54 ` [PATCH 2/3] reboot: Export reboot_mode Lee Jones
2021-08-03 15:54 ` [PATCH 3/3] power: reset: Enable tristate on restart power-off driver Lee Jones
2021-08-03 16:14   ` Sebastian Reichel
2021-08-05  7:50 [PATCH 0/3] power: reset: Convert Power-Off driver to tristate Lee Jones
2021-08-05  7:50 ` [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Lee Jones
2021-08-05  9:16   ` Thomas Bogendoerfer
2021-08-05 17:36   ` Catalin Marinas
2021-08-05 18:41     ` Greg Kroah-Hartman
2021-08-05 18:54       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRIxluiYdZo9OOAn@google.com \
    --to=lee.jones@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).