LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	LKML <linux-kernel@vger.kernel.org>,
	Openrisc <openrisc@lists.librecores.org>,
	kernel test robot <lkp@intel.com>,
	Jonas Bonn <jonas@southpole.se>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	Mike Rapoport <rppt@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] openrisc: Fix compiler warnings in setup
Date: Wed, 11 Aug 2021 06:13:59 +0900	[thread overview]
Message-ID: <YRLsF2J9KHb9F1BV@antec> (raw)
In-Reply-To: <0a3de28d-17d5-ec22-0ffb-97f5ca11c127@infradead.org>

On Sun, Aug 08, 2021 at 07:28:38PM -0700, Randy Dunlap wrote:
> On 8/8/21 6:31 PM, Guenter Roeck wrote:
> > On Thu, Aug 05, 2021 at 12:00:33PM +0900, Stafford Horne wrote:
> > > This was pointed out with the recent name change of or32_early_setup to
> > > or1k_early_setup.  Investigating the file I found a few other warnings
> > > so cleaning them up here.
> > > 
> > >      arch/openrisc/kernel/setup.c:220:13: warning: no previous prototype for 'or1k_early_setup' [-Wmissing-prototypes]
> > >        220 | void __init or1k_early_setup(void *fdt)
> > > 	  |             ^~~~~~~~~~~~~~~~
> > > 
> > > Fix this the missing or1k_early_setup prototype warning by adding an
> > > asm/setup.h file to define the prototype.
> > > 
> > >      arch/openrisc/kernel/setup.c:246:13: warning: no previous prototype for 'detect_unit_config' [-Wmissing-prototypes]
> > >        246 | void __init detect_unit_config(unsigned long upr, unsigned long mask,
> > > 	  |             ^~~~~~~~~~~~~~~~~~
> > > 
> > > The function detect_unit_config is not used, just remove it.
> > > 
> > >      arch/openrisc/kernel/setup.c:221: warning: Function parameter or member 'fdt' not described in 'or1k_early_setup'
> > > 
> > > Add @fdt docs to the function comment to suppress this warning.
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > 
> > Puzzled. This patch gives me:
> 
> Stafford posted a v2 earlier today:
> https://lore.kernel.org/lkml/20210808135437.3640549-1-shorne@gmail.com/

Yes, thanks for pointing this out.  I found why I missed this in v1,  basically
I failed to miss this using my local build and my CI service on travis seems to
have been stopped.  I have switched to use github actions for CI.

For my local build I will need to watch more carefully.

-Stafford

> > Building openrisc:or1ksim_defconfig ... failed
> > ------------
> > Error log:
> > In file included from ./arch/openrisc/include/asm/page.h:35,
> >                   from ./include/linux/generic-radix-tree.h:39,
> >                   from lib/generic-radix-tree.c:3:
> > ./arch/openrisc/include/asm/setup.h:11:13: error:
> > 		expected '=', ',', ';', 'asm' or '__attribute__' before 'or1k_early_setup'
> >     11 | void __init or1k_early_setup(void *fdt);
> >        |             ^~~~~~~~~~~~~~~~
> > make[1]: *** [scripts/Makefile.build:272: lib/generic-radix-tree.o] Error 1
> > 
> > Bisect log attached for completeness.
> 
> That needs #include <linux/init.h>
> 
> -- 
> ~Randy
> 

      reply	other threads:[~2021-08-10 21:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  3:00 Stafford Horne
2021-08-05 19:31 ` Randy Dunlap
2021-08-09  1:31 ` Guenter Roeck
2021-08-09  2:28   ` Randy Dunlap
2021-08-10 21:13     ` Stafford Horne [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRLsF2J9KHb9F1BV@antec \
    --to=shorne@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkp@intel.com \
    --cc=openrisc@lists.librecores.org \
    --cc=rdunlap@infradead.org \
    --cc=rppt@kernel.org \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=wangkefeng.wang@huawei.com \
    --subject='Re: [PATCH] openrisc: Fix compiler warnings in setup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).