LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: Replace BITn with BIT(n)
Date: Tue, 10 Aug 2021 23:50:34 +0100 [thread overview]
Message-ID: <YRMCug2ULtA6JoLn@equinox> (raw)
In-Reply-To: <20210810180511.8986-1-Larry.Finger@lwfinger.net>
On Tue, Aug 10, 2021 at 01:05:11PM -0500, Larry Finger wrote:
> The driver uses BITn instead of BIT(n). All such usage is converted.
>
> Note that this patch does not address any warnings that checkpatch
> will find. These include missing space around operators and lines
> that are too long. These problems will be addressed in a separate
> patch.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> ---
> v2 - Removed dependency on incorrect patch
> Fixed typo n comment noted by Dan Carpenter
> ---
> drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 40 +-
> drivers/staging/r8188eu/hal/odm.c | 68 +--
> drivers/staging/r8188eu/hal/odm_HWConfig.c | 4 +-
> drivers/staging/r8188eu/hal/odm_RTL8188E.c | 116 ++---
> drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 14 +-
> .../staging/r8188eu/hal/rtl8188e_hal_init.c | 66 +--
> drivers/staging/r8188eu/hal/rtl8188e_mp.c | 34 +-
> drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 8 +-
> drivers/staging/r8188eu/hal/rtl8188eu_led.c | 10 +-
> drivers/staging/r8188eu/hal/usb_halinit.c | 48 +-
> .../staging/r8188eu/include/Hal8188EPhyCfg.h | 14 +-
> .../staging/r8188eu/include/Hal8188EPwrSeq.h | 84 ++--
> drivers/staging/r8188eu/include/hal_intf.h | 16 +-
> drivers/staging/r8188eu/include/odm.h | 106 ++---
> drivers/staging/r8188eu/include/odm_reg.h | 2 +-
> drivers/staging/r8188eu/include/odm_types.h | 8 +-
> .../staging/r8188eu/include/osdep_service.h | 42 --
> .../staging/r8188eu/include/rtl8188e_spec.h | 415 ++++++++----------
> drivers/staging/r8188eu/include/rtw_sreset.h | 14 +-
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +-
> 21 files changed, 518 insertions(+), 597 deletions(-)
>
Dear Larry,
Looks good and builds fine for me.
Acked-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
prev parent reply other threads:[~2021-08-10 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 18:05 Larry Finger
2021-08-10 22:50 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRMCug2ULtA6JoLn@equinox \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--subject='Re: [PATCH v2] staging: r8188eu: Replace BITn with BIT(n)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).