LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Hari Prasath <Hari.PrasathGE@microchip.com>
Cc: nicolas.ferre@microchip.com, ludovic.desroches@microchip.com,
	robh@kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux@armlinux.org.uk
Subject: Re: [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments for sama5d29
Date: Thu, 12 Aug 2021 21:26:22 +0200	[thread overview]
Message-ID: <YRV13nfgpEEuOOxB@piout.net> (raw)
In-Reply-To: <20210812140758.28273-2-Hari.PrasathGE@microchip.com>

Hello,

On 12/08/2021 19:37:58+0530, Hari Prasath wrote:
> Add comments for the end user for modifying the DTS file for
> instantiating the sama5d29 SoC.
> 
> Signed-off-by: Hari Prasath <Hari.PrasathGE@microchip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index 627b7bf88d83..faa30063d9a9 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -6,6 +6,11 @@
>   *                2015 Nicolas Ferre <nicolas.ferre@atmel.com>
>   */
>  /dts-v1/;
> +/*
> + * Replace the line below with "sama5d29.dtsi" in order to instantiate the
> + * sama5d29 SoC of the sama5d2 family.Otherwise, leave it unchanged when
> + * using sama5d27 SoC for instance.
> + */

I guess it would be better to have a at91-sama5d29_xplained.dts (and we
should have had a at91-sama5d27_xplained.dts), else, you can't create an
image that will support both variants.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-08-12 19:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 14:07 [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file " Hari Prasath
2021-08-12 14:07 ` [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments " Hari Prasath
2021-08-12 19:26   ` Alexandre Belloni [this message]
2021-08-19 10:56     ` Hari.PrasathGE
2021-08-19 11:20       ` Alexandre Belloni
2021-09-21  9:44         ` Nicolas Ferre
2021-09-21 10:34 ` [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file " Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRV13nfgpEEuOOxB@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=Hari.PrasathGE@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh@kernel.org \
    --subject='Re: [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments for sama5d29' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).