LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file for sama5d29
@ 2021-08-12 14:07 Hari Prasath
  2021-08-12 14:07 ` [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments " Hari Prasath
  2021-09-21 10:34 ` [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file " Nicolas Ferre
  0 siblings, 2 replies; 7+ messages in thread
From: Hari Prasath @ 2021-08-12 14:07 UTC (permalink / raw)
  To: nicolas.ferre, alexandre.belloni, ludovic.desroches, robh,
	linux-arm-kernel, devicetree, linux-kernel, linux
  Cc: Hari.PrasathGE

A new dtsi file for sama5d29 SoC is added which basically inherits the sama5d2
dtsi with the mac controller compatible property updated.

Signed-off-by: Hari Prasath <Hari.PrasathGE@microchip.com>
---
 arch/arm/boot/dts/sama5d29.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/sama5d29.dtsi

diff --git a/arch/arm/boot/dts/sama5d29.dtsi b/arch/arm/boot/dts/sama5d29.dtsi
new file mode 100644
index 000000000000..e8cc73c0619f
--- /dev/null
+++ b/arch/arm/boot/dts/sama5d29.dtsi
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * sama5d29.dtsi - Device Tree Include file for SAMA5D29 SoC of the SAMA5D2
+ * family.
+ *
+ *  Copyright (C) 2021 Microchip Technology, Inc. and its subsidiaries
+ *
+ *  Author: Hari Prasath <Hari.PrasathGE@microchip.com>
+ *
+ */
+
+#include "sama5d2.dtsi"
+
+&macb0 {
+compatible = "atmel,sama5d29-gem";
+};
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments for sama5d29
  2021-08-12 14:07 [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file for sama5d29 Hari Prasath
@ 2021-08-12 14:07 ` Hari Prasath
  2021-08-12 19:26   ` Alexandre Belloni
  2021-09-21 10:34 ` [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file " Nicolas Ferre
  1 sibling, 1 reply; 7+ messages in thread
From: Hari Prasath @ 2021-08-12 14:07 UTC (permalink / raw)
  To: nicolas.ferre, alexandre.belloni, ludovic.desroches, robh,
	linux-arm-kernel, devicetree, linux-kernel, linux
  Cc: Hari.PrasathGE

Add comments for the end user for modifying the DTS file for
instantiating the sama5d29 SoC.

Signed-off-by: Hari Prasath <Hari.PrasathGE@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index 627b7bf88d83..faa30063d9a9 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -6,6 +6,11 @@
  *                2015 Nicolas Ferre <nicolas.ferre@atmel.com>
  */
 /dts-v1/;
+/*
+ * Replace the line below with "sama5d29.dtsi" in order to instantiate the
+ * sama5d29 SoC of the sama5d2 family.Otherwise, leave it unchanged when
+ * using sama5d27 SoC for instance.
+ */
 #include "sama5d2.dtsi"
 #include "sama5d2-pinfunc.h"
 #include <dt-bindings/mfd/atmel-flexcom.h>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments for sama5d29
  2021-08-12 14:07 ` [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments " Hari Prasath
@ 2021-08-12 19:26   ` Alexandre Belloni
  2021-08-19 10:56     ` Hari.PrasathGE
  0 siblings, 1 reply; 7+ messages in thread
From: Alexandre Belloni @ 2021-08-12 19:26 UTC (permalink / raw)
  To: Hari Prasath
  Cc: nicolas.ferre, ludovic.desroches, robh, linux-arm-kernel,
	devicetree, linux-kernel, linux

Hello,

On 12/08/2021 19:37:58+0530, Hari Prasath wrote:
> Add comments for the end user for modifying the DTS file for
> instantiating the sama5d29 SoC.
> 
> Signed-off-by: Hari Prasath <Hari.PrasathGE@microchip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index 627b7bf88d83..faa30063d9a9 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -6,6 +6,11 @@
>   *                2015 Nicolas Ferre <nicolas.ferre@atmel.com>
>   */
>  /dts-v1/;
> +/*
> + * Replace the line below with "sama5d29.dtsi" in order to instantiate the
> + * sama5d29 SoC of the sama5d2 family.Otherwise, leave it unchanged when
> + * using sama5d27 SoC for instance.
> + */

I guess it would be better to have a at91-sama5d29_xplained.dts (and we
should have had a at91-sama5d27_xplained.dts), else, you can't create an
image that will support both variants.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments for sama5d29
  2021-08-12 19:26   ` Alexandre Belloni
@ 2021-08-19 10:56     ` Hari.PrasathGE
  2021-08-19 11:20       ` Alexandre Belloni
  0 siblings, 1 reply; 7+ messages in thread
From: Hari.PrasathGE @ 2021-08-19 10:56 UTC (permalink / raw)
  To: alexandre.belloni
  Cc: Nicolas.Ferre, Ludovic.Desroches, robh, linux-arm-kernel,
	devicetree, linux-kernel, linux

Hello,

On 13/08/21 12:56 am, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hello,
> 
> On 12/08/2021 19:37:58+0530, Hari Prasath wrote:
>> Add comments for the end user for modifying the DTS file for
>> instantiating the sama5d29 SoC.
>>
>> Signed-off-by: Hari Prasath <Hari.PrasathGE@microchip.com>
>> ---
>>   arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> index 627b7bf88d83..faa30063d9a9 100644
>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> @@ -6,6 +6,11 @@
>>    *                2015 Nicolas Ferre <nicolas.ferre@atmel.com>
>>    */
>>   /dts-v1/;
>> +/*
>> + * Replace the line below with "sama5d29.dtsi" in order to instantiate the
>> + * sama5d29 SoC of the sama5d2 family.Otherwise, leave it unchanged when
>> + * using sama5d27 SoC for instance.
>> + */
> 
> I guess it would be better to have a at91-sama5d29_xplained.dts (and we
> should have had a at91-sama5d27_xplained.dts), else, you can't create an
> image that will support both variants.
> 
> 
The new SoC 'sama5d29' belongs to the same sama5d2 family. It is 
essentially a new chip revision of the existing sama5d27 with a new GMAC 
controller IP that addresses few silicon issues. There wouldn't be 
separate evaluation boards that shall be made but we will be using the 
existing sama5d2 XPlained boards itself but with the new SoC populated. 
Hence we have taken this approach of having a separate DTSI file and 
reuse the existing board specific DTS file.

We don't want to create single image that will support both variants. In 
fact, we don't want our customers to enable certain features that are 
broken at the silicon level in the existing revision of the SoC i.e 
sama5d27. Instead, they could do this change manually and use it in the 
new SoC i.e sama5d29.

Regards,
Hari

> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments for sama5d29
  2021-08-19 10:56     ` Hari.PrasathGE
@ 2021-08-19 11:20       ` Alexandre Belloni
  2021-09-21  9:44         ` Nicolas Ferre
  0 siblings, 1 reply; 7+ messages in thread
From: Alexandre Belloni @ 2021-08-19 11:20 UTC (permalink / raw)
  To: Hari.PrasathGE
  Cc: Nicolas.Ferre, Ludovic.Desroches, robh, linux-arm-kernel,
	devicetree, linux-kernel, linux

On 19/08/2021 10:56:21+0000, Hari.PrasathGE@microchip.com wrote:
> Hello,
> 
> On 13/08/21 12:56 am, Alexandre Belloni wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > Hello,
> > 
> > On 12/08/2021 19:37:58+0530, Hari Prasath wrote:
> >> Add comments for the end user for modifying the DTS file for
> >> instantiating the sama5d29 SoC.
> >>
> >> Signed-off-by: Hari Prasath <Hari.PrasathGE@microchip.com>
> >> ---
> >>   arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 +++++
> >>   1 file changed, 5 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> >> index 627b7bf88d83..faa30063d9a9 100644
> >> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> >> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> >> @@ -6,6 +6,11 @@
> >>    *                2015 Nicolas Ferre <nicolas.ferre@atmel.com>
> >>    */
> >>   /dts-v1/;
> >> +/*
> >> + * Replace the line below with "sama5d29.dtsi" in order to instantiate the
> >> + * sama5d29 SoC of the sama5d2 family.Otherwise, leave it unchanged when
> >> + * using sama5d27 SoC for instance.
> >> + */
> > 
> > I guess it would be better to have a at91-sama5d29_xplained.dts (and we
> > should have had a at91-sama5d27_xplained.dts), else, you can't create an
> > image that will support both variants.
> > 
> > 
> The new SoC 'sama5d29' belongs to the same sama5d2 family. It is 
> essentially a new chip revision of the existing sama5d27 with a new GMAC 
> controller IP that addresses few silicon issues. There wouldn't be 
> separate evaluation boards that shall be made but we will be using the 
> existing sama5d2 XPlained boards itself but with the new SoC populated. 

That's what I understood but a board with a different SoC is a
different board.

> Hence we have taken this approach of having a separate DTSI file and 
> reuse the existing board specific DTS file.
> 
> We don't want to create single image that will support both variants. In 
> fact, we don't want our customers to enable certain features that are 
> broken at the silicon level in the existing revision of the SoC i.e 
> sama5d27. Instead, they could do this change manually and use it in the 
> new SoC i.e sama5d29.
> 

This will be confusing to your customers while you could make their
lives simpler by having the bootloader chose the proper dtb instead of
having them change that manually. They will then have to regenerate
images with that change, see how your customers struggle to do that:

https://stackoverflow.com/questions/68222619/update-custom-device-tree-on-yocto
https://stackoverflow.com/questions/37347808/how-to-use-an-own-device-tree-and-modified-kernel-config-in-yocto
https://stackoverflow.com/questions/63047955/overriding-defconfig-in-bbappend-file


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments for sama5d29
  2021-08-19 11:20       ` Alexandre Belloni
@ 2021-09-21  9:44         ` Nicolas Ferre
  0 siblings, 0 replies; 7+ messages in thread
From: Nicolas Ferre @ 2021-09-21  9:44 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Ludovic.Desroches, robh, linux-arm-kernel, devicetree,
	linux-kernel, linux, Hari.PrasathGE

On 19/08/2021 at 13:20, Alexandre Belloni wrote:
> On 19/08/2021 10:56:21+0000, Hari.PrasathGE@microchip.com wrote:
>> Hello,
>>
>> On 13/08/21 12:56 am, Alexandre Belloni wrote:
>>> Hello,
>>>
>>> On 12/08/2021 19:37:58+0530, Hari Prasath wrote:
>>>> Add comments for the end user for modifying the DTS file for
>>>> instantiating the sama5d29 SoC.
>>>>
>>>> Signed-off-by: Hari Prasath <Hari.PrasathGE@microchip.com>
>>>> ---
>>>>    arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>>> index 627b7bf88d83..faa30063d9a9 100644
>>>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>>> @@ -6,6 +6,11 @@
>>>>     *                2015 Nicolas Ferre <nicolas.ferre@atmel.com>
>>>>     */
>>>>    /dts-v1/;
>>>> +/*
>>>> + * Replace the line below with "sama5d29.dtsi" in order to instantiate the
>>>> + * sama5d29 SoC of the sama5d2 family.Otherwise, leave it unchanged when
>>>> + * using sama5d27 SoC for instance.
>>>> + */
>>>
>>> I guess it would be better to have a at91-sama5d29_xplained.dts (and we
>>> should have had a at91-sama5d27_xplained.dts), else, you can't create an
>>> image that will support both variants.
>>>
>>>
>> The new SoC 'sama5d29' belongs to the same sama5d2 family. It is
>> essentially a new chip revision of the existing sama5d27 with a new GMAC
>> controller IP that addresses few silicon issues. There wouldn't be
>> separate evaluation boards that shall be made but we will be using the
>> existing sama5d2 XPlained boards itself but with the new SoC populated.
> 
> That's what I understood but a board with a different SoC is a
> different board.

The problem that we have right now is that the official board sama5d2 
Xplained will never be officially released with a sama5d29 SoC. There's 
basically no available board with this chip.

We added this "hint" as a comment to our historical board but it's true 
that it might be confusing.

For now, I'm taking only the first patch of the series. If the need 
arise, we'll create the proper board DTS file.

>> Hence we have taken this approach of having a separate DTSI file and
>> reuse the existing board specific DTS file.
>>
>> We don't want to create single image that will support both variants. In
>> fact, we don't want our customers to enable certain features that are
>> broken at the silicon level in the existing revision of the SoC i.e
>> sama5d27. Instead, they could do this change manually and use it in the
>> new SoC i.e sama5d29.
>>
> 
> This will be confusing to your customers while you could make their
> lives simpler by having the bootloader chose the proper dtb instead of
> having them change that manually. They will then have to regenerate
> images with that change, see how your customers struggle to do that:
> 
> https://stackoverflow.com/questions/68222619/update-custom-device-tree-on-yocto
> https://stackoverflow.com/questions/37347808/how-to-use-an-own-device-tree-and-modified-kernel-config-in-yocto
> https://stackoverflow.com/questions/63047955/overriding-defconfig-in-bbappend-file
Yes, understood. The intention was not to create another different board 
but to give a hint, should customer replace themselves the SoC on 
official sama5d2 xplained board (like we did internally). Use case is 
probably so unlikely that we might just forget about it (for now at least).

Best regards,
   Nicolas

-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file for sama5d29
  2021-08-12 14:07 [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file for sama5d29 Hari Prasath
  2021-08-12 14:07 ` [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments " Hari Prasath
@ 2021-09-21 10:34 ` Nicolas Ferre
  1 sibling, 0 replies; 7+ messages in thread
From: Nicolas Ferre @ 2021-09-21 10:34 UTC (permalink / raw)
  To: Hari Prasath, alexandre.belloni, ludovic.desroches, robh,
	linux-arm-kernel, devicetree, linux-kernel, linux

On 12/08/2021 at 16:07, Hari Prasath wrote:
> A new dtsi file for sama5d29 SoC is added which basically inherits the sama5d2
> dtsi with the mac controller compatible property updated.
> 
> Signed-off-by: Hari Prasath <Hari.PrasathGE@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
And added to our at91-dt branch for 5.16.

Best regards,
    Nicolas

> ---
>   arch/arm/boot/dts/sama5d29.dtsi | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>   create mode 100644 arch/arm/boot/dts/sama5d29.dtsi
> 
> diff --git a/arch/arm/boot/dts/sama5d29.dtsi b/arch/arm/boot/dts/sama5d29.dtsi
> new file mode 100644
> index 000000000000..e8cc73c0619f
> --- /dev/null
> +++ b/arch/arm/boot/dts/sama5d29.dtsi
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * sama5d29.dtsi - Device Tree Include file for SAMA5D29 SoC of the SAMA5D2
> + * family.
> + *
> + *  Copyright (C) 2021 Microchip Technology, Inc. and its subsidiaries
> + *
> + *  Author: Hari Prasath <Hari.PrasathGE@microchip.com>
> + *
> + */
> +
> +#include "sama5d2.dtsi"
> +
> +&macb0 {
> +compatible = "atmel,sama5d29-gem";
> +};
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-09-21 10:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12 14:07 [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file for sama5d29 Hari Prasath
2021-08-12 14:07 ` [PATCH 2/2] ARM: at91: dts: at91-sama5d2_xplained: Add comments " Hari Prasath
2021-08-12 19:26   ` Alexandre Belloni
2021-08-19 10:56     ` Hari.PrasathGE
2021-08-19 11:20       ` Alexandre Belloni
2021-09-21  9:44         ` Nicolas Ferre
2021-09-21 10:34 ` [PATCH 1/2] ARM: at91: dts: sama5d29: Add dtsi file " Nicolas Ferre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).