From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19DFEC432BE for ; Thu, 12 Aug 2021 19:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F02486103A for ; Thu, 12 Aug 2021 19:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233714AbhHLTSS (ORCPT ); Thu, 12 Aug 2021 15:18:18 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:60898 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233593AbhHLTSP (ORCPT ); Thu, 12 Aug 2021 15:18:15 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 529A9EE; Thu, 12 Aug 2021 21:17:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1628795868; bh=TWW79F57UGZaMYBF0Q9p1yrePqna1CBLge7LfxvzIbU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EEqsh/dhGecZeeNNVwxkA393Rb9YQVaeo4a/kr64ON1gPSjK0FxGvvwNcPbcn2Kb5 0L+eTiIVKnEBlN2K9oAWLl6iUaGk7an/eK+iXBFNdFpvD19BcoqkoLpYOHQPtoyYmX ZLfZFxqshDGMumVXqXooOVXR97FRx9pa+NG/wQVI= Date: Thu, 12 Aug 2021 22:17:44 +0300 From: Laurent Pinchart To: Rob Clark Cc: dri-devel , linux-arm-msm , freedreno , Stephen Boyd , Douglas Anderson , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Subject: Re: [PATCH 3/4] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid() Message-ID: References: <20210811235253.924867-1-robdclark@gmail.com> <20210811235253.924867-4-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Thu, Aug 12, 2021 at 12:09:12PM -0700, Rob Clark wrote: > On Thu, Aug 12, 2021 at 11:44 AM Laurent Pinchart wrote: > > On Wed, Aug 11, 2021 at 04:52:49PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > For the brave new world of bridges not creating their own connectors, we > > > need to implement the max clock limitation via bridge->mode_valid() > > > instead of connector->mode_valid(). > > > > > > Signed-off-by: Rob Clark > > > --- > > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 24 +++++++++++++++++++----- > > > 1 file changed, 19 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > > index 5d3b30b2f547..38dcc49eccaf 100644 > > > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > > @@ -595,6 +595,15 @@ static struct auxiliary_driver ti_sn_aux_driver = { > > > .id_table = ti_sn_aux_id_table, > > > }; > > > > > > +static enum drm_mode_status check_mode(const struct drm_display_mode *mode) > > > +{ > > > + /* maximum supported resolution is 4K at 60 fps */ > > > + if (mode->clock > 594000) > > > + return MODE_CLOCK_HIGH; > > > + > > > + return MODE_OK; > > > +} > > > + > > > /* ----------------------------------------------------------------------------- > > > * DRM Connector Operations > > > */ > > > @@ -616,11 +625,7 @@ static enum drm_mode_status > > > ti_sn_bridge_connector_mode_valid(struct drm_connector *connector, > > > struct drm_display_mode *mode) > > > { > > > - /* maximum supported resolution is 4K at 60 fps */ > > > - if (mode->clock > 594000) > > > - return MODE_CLOCK_HIGH; > > > - > > > - return MODE_OK; > > > + return check_mode(mode); > > > > Do we need to implement the connector .mode_valid() operation, given > > that the bridge is linked in the chain ? > > My understanding is that we need to keep it for display drivers that > are not converted to NO_CONNECTOR.. > > But AFAIK snapdragon is the only upstream user of this bridge, so > after the drm/msm/dsi patch lands we could probably garbage collect > the connector support. Even in the !NO_CONNECTOR case, the bridge will still be linked in the chain, so the atomic helpers should call the bridge .mode_valid() in addition to the connector .mode_valid(). I think the connector operation is redundant. > > > } > > > > > > static struct drm_connector_helper_funcs ti_sn_bridge_connector_helper_funcs = { > > > @@ -763,6 +768,14 @@ static void ti_sn_bridge_detach(struct drm_bridge *bridge) > > > drm_dp_aux_unregister(&bridge_to_ti_sn65dsi86(bridge)->aux); > > > } > > > > > > +static enum drm_mode_status > > > +ti_sn_bridge_mode_valid(struct drm_bridge *bridge, > > > + const struct drm_display_info *info, > > > + const struct drm_display_mode *mode) > > > +{ > > > + return check_mode(mode); > > > +} > > > + > > > static void ti_sn_bridge_disable(struct drm_bridge *bridge) > > > { > > > struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge); > > > @@ -1118,6 +1131,7 @@ static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) > > > static const struct drm_bridge_funcs ti_sn_bridge_funcs = { > > > .attach = ti_sn_bridge_attach, > > > .detach = ti_sn_bridge_detach, > > > + .mode_valid = ti_sn_bridge_mode_valid, > > > .pre_enable = ti_sn_bridge_pre_enable, > > > .enable = ti_sn_bridge_enable, > > > .disable = ti_sn_bridge_disable, -- Regards, Laurent Pinchart