LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Dan Schatzberg <schatzberg.dan@gmail.com>,
cgroups@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH V4 0/7] loop: cleanup charging io to mem/blkcg
Date: Sat, 14 Aug 2021 17:12:46 +0800 [thread overview]
Message-ID: <YReJDkp8kswVdvBj@T590> (raw)
In-Reply-To: <20210812090037.GE2867@lst.de>
Hi Christoph,
On Thu, Aug 12, 2021 at 11:00:37AM +0200, Christoph Hellwig wrote:
> On Tue, Aug 10, 2021 at 11:26:54AM +0800, Ming Lei wrote:
> > Can you share us what your expectations are in the re-write? Such as:
> >
> > 1) no impact on normal non-cgroup path
> > 2) ...
> > 3) ...
>
> Get the call cgroup mess out of this driver entirely?
Firstly the patch 2/7 in this series cleans up cgroup references by
killing unnecessary #ifdef and moving cgroup references into common
helpers, and the cgroup uses have been cleaned a lot.
Secondly the issue is that we need to wire proper cgroups(blkcg & memcg) for
loop's IO because loop uses wq or kthread for handling IO, and IMO it isn't
possible to moving cgroup references out of loop entirely if we want to
support this cgroup's function for loop driver.
Finally the current cgroup reference is actually very simple: retrieve
blkcg from bio_blkcg(bio) and memcg from the the blkcg. Then applies
the two in the single function of loop_workfn() only.
Thanks,
Ming
prev parent reply other threads:[~2021-08-14 9:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 8:02 Ming Lei
2021-08-06 8:02 ` [PATCH V4 1/7] mm: memcontrol: add helper of memcg_get_e_css Ming Lei
2021-08-12 8:58 ` Christoph Hellwig
2021-08-06 8:02 ` [PATCH V4 2/7] loop: clean up blkcg association Ming Lei
2021-08-12 8:59 ` Christoph Hellwig
2021-08-06 8:02 ` [PATCH V4 3/7] loop: conver timer for monitoring idle worker into dwork Ming Lei
2021-08-06 8:02 ` [PATCH V4 4/7] loop: add __loop_free_idle_workers() for covering freeing workers in clearing FD Ming Lei
2021-08-06 8:03 ` [PATCH V4 5/7] loop: improve loop_process_work Ming Lei
2021-08-06 8:03 ` [PATCH V4 6/7] loop: use xarray to store workers Ming Lei
2021-08-06 8:03 ` [PATCH V4 7/7] loop: don't add worker into idle list Ming Lei
2021-08-09 6:41 ` [PATCH V4 0/7] loop: cleanup charging io to mem/blkcg Christoph Hellwig
2021-08-10 3:26 ` Ming Lei
2021-08-12 9:00 ` Christoph Hellwig
2021-08-14 9:12 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YReJDkp8kswVdvBj@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schatzberg.dan@gmail.com \
--cc=tj@kernel.org \
--subject='Re: [PATCH V4 0/7] loop: cleanup charging io to mem/blkcg' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).