From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A500AC432BE for ; Sun, 15 Aug 2021 06:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 883166103D for ; Sun, 15 Aug 2021 06:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235251AbhHOG0Z (ORCPT ); Sun, 15 Aug 2021 02:26:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:42544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231238AbhHOG0Y (ORCPT ); Sun, 15 Aug 2021 02:26:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EFA716103A; Sun, 15 Aug 2021 06:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629008754; bh=8WgvM8M26oXRN4vw+Mt7hS5lSyYMjCSVo0s4LtoabEM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pq5hMcRQjpEiOkegtUosI+prQg3jdqGJ3o+6wh3SJ7FOvtWgbGrGnUGMLjkWMlV7d 7UbYtLGv5+PCeOXE8od97iS9Hw5BNkVPimXmtmPnAD7IZXEtbZaay0eBigfeFInE5w yRKWYFcBZZ+3qP6KZMdAWR8QO47lcAZd+iRWytUI= Date: Sun, 15 Aug 2021 08:25:51 +0200 From: Greg Kroah-Hartman To: daniel watson Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:iio:ade7854 surround complex defines in parentheses Message-ID: References: <20210815023115.13016-1-ozzloy@challenge-bot.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210815023115.13016-1-ozzloy@challenge-bot.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 14, 2021 at 07:31:15PM -0700, daniel watson wrote: > Error found by checkpatch.pl What error? > > Signed-off-by: daniel watson Capitalize your name? > --- > drivers/staging/iio/meter/ade7854.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/meter/ade7854.h b/drivers/staging/iio/meter/ade7854.h > index a51e6e3183d38..afb13e21002e1 100644 > --- a/drivers/staging/iio/meter/ade7854.h > +++ b/drivers/staging/iio/meter/ade7854.h > @@ -139,9 +139,9 @@ > #define ADE7854_MAX_RX 7 > #define ADE7854_STARTUP_DELAY 1000 > > -#define ADE7854_SPI_SLOW (u32)(300 * 1000) > -#define ADE7854_SPI_BURST (u32)(1000 * 1000) > -#define ADE7854_SPI_FAST (u32)(2000 * 1000) > +#define ADE7854_SPI_SLOW ((u32)(300 * 1000)) > +#define ADE7854_SPI_BURST ((u32)(1000 * 1000)) > +#define ADE7854_SPI_FAST ((u32)(2000 * 1000)) This is not a real change that is needed, just look at the code to verify that. thanks, greg k-h