LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
	Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG
Date: Mon, 16 Aug 2021 08:43:53 +0100	[thread overview]
Message-ID: <YRoXOTRstjKEojuA@google.com> (raw)
In-Reply-To: <87fsvgp4jd.ffs@tglx>

On Wed, 11 Aug 2021, Thomas Gleixner wrote:

> On Wed, Aug 11 2021 at 08:57, Lee Jones wrote:
> > On Tue, 10 Aug 2021, Thomas Gleixner wrote:
> >> > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d)
> >> >  		 * If this happens then there was a missed IRQ fixup at some
> >> >  		 * point. Warn about it and enforce fixup.
> >> >  		 */
> >> > -		pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
> >> 
> >> This one is clearly a warning as this should not happen. See the
> >> comments around that.
> >> 
> >> > +		pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
> >> >  			cpumask_pr_args(m), d->irq, cpu);
> >> >  		return true;
> >> >  	}
> >> > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void)
> >> >  		raw_spin_unlock(&desc->lock);
> >> >  
> >> >  		if (affinity_broken) {
> >> > -			pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> >> > +			pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> >> >  					    irq, smp_processor_id());
> >> 
> >> Maybe, but distro people might have opinions on that.
> >
> > The trouble is, even if these are real warnings, they have an affect
> > on performance on real products.  To the point where so much logging
> > builds up during pre-release testing, that it sets off the watchdog(s)
> > on some high profile consumer devices.
> 
> I'm fine with making the second one debug, but the first one really
> should not trigger at all.

Understood.  I'll follow-up with a subsequent patch and report back
with your advice.  Thanks Thomas.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

      reply	other threads:[~2021-08-16  7:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  7:31 Lee Jones
2021-08-10 14:21 ` Thomas Gleixner
2021-08-11  7:57   ` Lee Jones
2021-08-11 12:08     ` Thomas Gleixner
2021-08-16  7:43       ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRoXOTRstjKEojuA@google.com \
    --to=lee.jones@linaro.org \
    --cc=hare@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).