LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Rapoport <rppt@linux.ibm.com>,
	Peter Collingbourne <pcc@google.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmflags.h: add missing __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON names
Date: Tue, 17 Aug 2021 07:59:31 +0300	[thread overview]
Message-ID: <YRtCM/ZC+nWHQmey@kernel.org> (raw)
In-Reply-To: <20210816170510.9d6afcd53c767397aba758ef@linux-foundation.org>

On Mon, Aug 16, 2021 at 05:05:10PM -0700, Andrew Morton wrote:
> On Mon, 16 Aug 2021 16:35:02 +0300 Mike Rapoport <rppt@kernel.org> wrote:
> 
> > From: Mike Rapoport <rppt@linux.ibm.com>
> > 
> > Add missing names of __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON flags to
> > __def_gfpflag_names.
> > 
> > Fixes: 013bb59dbb7c ("arm64: mte: handle tags zeroing at page allocation time")
> > Fixes: c275c5c6d50a ("kasan: disable freed user page poisoning with HW tags")
> 
> "fixes" in what way?  ie, what problems were caused by the above commits?
> 
> > --- a/include/trace/events/mmflags.h
> > +++ b/include/trace/events/mmflags.h
> > @@ -48,7 +48,9 @@
> >  	{(unsigned long)__GFP_WRITE,		"__GFP_WRITE"},		\
> >  	{(unsigned long)__GFP_RECLAIM,		"__GFP_RECLAIM"},	\
> >  	{(unsigned long)__GFP_DIRECT_RECLAIM,	"__GFP_DIRECT_RECLAIM"},\
> > -	{(unsigned long)__GFP_KSWAPD_RECLAIM,	"__GFP_KSWAPD_RECLAIM"}\
> > +	{(unsigned long)__GFP_KSWAPD_RECLAIM,	"__GFP_KSWAPD_RECLAIM"},\
> > +	{(unsigned long)__GFP_ZEROTAGS,		"__GFP_ZEROTAGS"},	\
> > +	{(unsigned long)__GFP_SKIP_KASAN_POISON,"__GFP_SKIP_KASAN_POISON"}\
> >  
> >  #define show_gfp_flags(flags)						\
> >  	(flags) ? __print_flags(flags, "|",				\
> 
> I'm guessing that the tracing output was messed up in some fashion?

I didn't check tracing actually, but printk("%pGg") outputs these two flags
as hexadecimal number, rather that string, e.g:

	GFP_KERNEL|0x1800000 

-- 
Sincerely yours,
Mike.

      reply	other threads:[~2021-08-17  4:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 13:35 Mike Rapoport
2021-08-17  0:05 ` Andrew Morton
2021-08-17  4:59   ` Mike Rapoport [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRtCM/ZC+nWHQmey@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pcc@google.com \
    --cc=rostedt@goodmis.org \
    --cc=rppt@linux.ibm.com \
    --subject='Re: [PATCH] mmflags.h: add missing __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON names' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).