From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EAB7C4338F for ; Tue, 17 Aug 2021 06:12:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C31D60E78 for ; Tue, 17 Aug 2021 06:12:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234440AbhHQGM6 (ORCPT ); Tue, 17 Aug 2021 02:12:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:56782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233676AbhHQGM6 (ORCPT ); Tue, 17 Aug 2021 02:12:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D086660F41; Tue, 17 Aug 2021 06:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629180745; bh=hTwVpjGmUak1NMjM8ZG/8L0yy9w3IguhLNQ5Da//1P8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B5oCMcykDIhmhfDiqIa2ExpFHt1RQPJiCW1KMCjT37jDHPFNNHK8J1aQM58RRYY1A pHdAqxIJsU1HZlRwhnQEPL6S5G/7PhJyf9MYiDNExP/sV1khiOogItCqao3KkLWS2x dgOCECW/6Io+UV0mqQOjC6Bjvuy0fQ9C7wZ61R5c= Date: Tue, 17 Aug 2021 08:12:22 +0200 From: Greg Kroah-Hartman To: daniel watson Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:iio:ade7854 surround complex defines in parentheses Message-ID: References: <20210815023115.13016-1-ozzloy@challenge-bot.com> <20210817043038.GA9492@challenge-bot.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210817043038.GA9492@challenge-bot.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 09:30:38PM -0700, daniel watson wrote: > > If this is a false positive from checkpatch, I can submit it as an > example to the checkpatch maintainers. Do you think I should? checkpatch is a perl script that does pattern matching, it is really hard for it to determine for things like this specific example, that it is not needed. Try finding other valid checkpatch cleanups if you wish to contribute in this way, there are loads of others under drivers/staging/ that should be easy to find. thanks, greg k-h